Skip to content

Increase rh-ecosystem-edge ocp-4-17-0 clusterpool runningCount to 6#78839

Open
TomerNewman wants to merge 1 commit intoopenshift:mainfrom
TomerNewman:rh-ecosystem-edge-ocp-4-17-running-count
Open

Increase rh-ecosystem-edge ocp-4-17-0 clusterpool runningCount to 6#78839
TomerNewman wants to merge 1 commit intoopenshift:mainfrom
TomerNewman:rh-ecosystem-edge-ocp-4-17-running-count

Conversation

@TomerNewman
Copy link
Copy Markdown
Contributor

@TomerNewman TomerNewman commented May 5, 2026

/cc @ybettan

Summary by CodeRabbit

  • Infrastructure Updates
    • Increased available cluster instances from 1 to 6, expanding capacity and resource availability.

@openshift-ci openshift-ci Bot requested a review from ybettan May 5, 2026 14:26
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b468d03f-fd95-4f3c-a28d-ae0a0a9853e9

📥 Commits

Reviewing files that changed from the base of the PR and between 463d1f3 and 3059f18.

📒 Files selected for processing (1)
  • clusters/hosted-mgmt/hive/pools/rh-ecosystem-edge/ocp-4-17-0_clusterpool.yaml

Walkthrough

The PR updates the ClusterPool status for the RH Ecosystem Edge cluster pool at OCP version 4.17.0, increasing the runningCount from 1 to 6 to reflect the current operational state.

Changes

Cluster Pool Status Update

Layer / File(s) Summary
Status Field Update
clusters/hosted-mgmt/hive/pools/rh-ecosystem-edge/ocp-4-17-0_clusterpool.yaml
status.runningCount incremented from 1 to 6 to reflect the current number of running cluster instances.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and clearly summarizes the main change: increasing the runningCount for the rh-ecosystem-edge ocp-4-17-0 clusterpool from 1 to 6.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only a Kubernetes YAML configuration file (ClusterPool), not test code. The check for stable Ginkgo test names is not applicable as there are no tests in this PR.
Test Structure And Quality ✅ Passed The custom check requires reviewing Ginkgo test code for quality patterns. This PR only modifies a Kubernetes ClusterPool YAML configuration file (no test code). The check is not applicable.
Microshift Test Compatibility ✅ Passed The PR adds a YAML configuration file for a ClusterPool resource with no Ginkgo e2e tests. The MicroShift Test Compatibility check is not applicable to configuration files.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies a ClusterPool YAML configuration file. No Ginkgo e2e tests are added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR updates only ClusterPool runningCount (cluster provisioning config), not deployment manifests, operator code, or pod scheduling constraints. No topology-aware scheduling issues apply.
Ote Binary Stdout Contract ✅ Passed Check not applicable. PR modifies only YAML configuration (ClusterPool resource), not executable code or binaries. No process-level code that could violate OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. The change is to a Kubernetes ClusterPool YAML configuration file that only updates the runningCount field. The custom check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

pullSecretRef:
name: pull-secret
runningCount: 1
runningCount: 6
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it for all out cluster pools. If the default behavior changed for the 4.17 pool it will happened for all other pools as described in https://redhat-internal.slack.com/archives/CBN38N3MW/p1777895904673439?thread_ts=1777184830.923239&cid=CBN38N3MW

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 5, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@TomerNewman: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

@TomerNewman: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@TomerNewman
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants