MCO-2114: adds io.openshift.os.streamclass to OKD OS and extensions images

[cheesesashimi]

To support a singular OS Stream in OKD, we need to add a label to the SCOS 10 image (io.openshift.os.streamclass). For RHCOS 10, this label is set within the build-node-image.Jenkinsfile. Since the value of this label depends on whether it is an RHCOS 9 or RHCOS 10 image, the value must be set at build-time instead of via the Containerfile. Since OKD will only have one OS Stream (centos-10), we could set it statically in the Containerfile(s) found in https://github.com/openshift/os. However, I think it makes more sense to do it at build-time until there is a better way of setting it dynamically.

With the above in mind, this PR accomplishes that by modifying the image targets to be the input for an inline Containerfile which sets this label.

[cheesesashimi]

/pj-rehearse pull-ci-openshift-os-master-okd-scos-images

[openshift-ci-robot]

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[dustymabe]

The code in the PR seems reasonable. The actual string suggested here may be able to be improved. For rhcos 9 and rhcos 10 the string we are using for the stream class is rhel-9 and rhel-10. I'm not sure if we want scos-10 here or centos-10.

[cheesesashimi]

I have no objection with either scos-10, centos-10, or even stream-10. My only thought is that whatever identifier we use, it should be consistent throughout.

[dustymabe]

I have no objection with either scos-10, centos-10, or even stream-10. My only thought is that whatever identifier we use, it should be consistent throughout.

I have the same sentiment, with a slight lean towards centos-10 since it seems to match more closely with what we are doing for streamclass for RHCOS (i.e. rhel-10).

[cheesesashimi]

I just pushed a commit to change it to centos-10.

[cheesesashimi]

/pj-rehearse pull-ci-openshift-os-master-okd-scos-images

[openshift-ci-robot]

@cheesesashimi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@cheesesashimi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-os-master-okd-scos-e2e-aws-ovn	openshift/os	presubmit	Ci-operator config changed
pull-ci-openshift-os-master-okd-scos-images	openshift/os	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[dustymabe]

The label part of the PR lgtm. I'm not sure about the other changes.

Should we have someone from okd review this? @Prashanth684 ?

[Prashanth684]

/pj-rehearse pull-ci-openshift-os-master-okd-scos-images

[openshift-ci-robot]

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@cheesesashimi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@cheesesashimi: This pull request references MCO-2114 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

To support a singular OS Stream in OKD, we need to add a label to the SCOS 10 image (io.openshift.os.streamclass). For RHCOS 10, this label is set within the build-node-image.Jenkinsfile. Since the value of this label depends on whether it is an RHCOS 9 or RHCOS 10 image, the value must be set at build-time instead of via the Containerfile. Since OKD will only have one OS Stream (centos-10), we could set it statically in the Containerfile(s) found in https://github.com/openshift/os. However, I think it makes more sense to do it at build-time until there is a better way of setting it dynamically.

With the above in mind, this PR accomplishes that by modifying the image targets to be the input for an inline Containerfile which sets this label.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Prashanth684]

/lgtm

[Prashanth684]

checked the image created from the rehearsal job and it has the label set

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cheesesashimi, Prashanth684
Once this PR has been reviewed and has the lgtm label, please assign gursewak1997 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/os/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment