Open
Conversation
…s-vcm The ref.yaml files for ipi-conf-vsphere-lb-external and ipi-conf-vsphere-vips-vcm already point to their Python replacements (.py files). The .sh scripts had deprecation comments stating they were 'left behind temporarily while we migrate to python' -- the migration is complete and these files are no longer executed.
Wire up the existing Python replacements for ipi-conf-vsphere-dns and ipi-deprovision-vsphere-dns by updating their ref.yaml files to point to the .py scripts instead of .sh. The shell scripts had deprecation comments but were never actually switched over -- the Python files already existed but weren't referenced. Changes to ref.yaml: - commands: .sh -> .py - from: tools -> vsphere-ci-python (for boto3 availability) - add run_as_script: true (required for Python execution)
Merge the VCM (vsphere-elastic) and legacy code paths into a single script that branches on CLUSTER_PROFILE_NAME. The scripts were ~80% identical -- the only difference was the iteration source (platform.json failure domains for VCM vs file-based datacenter/datastore arrays for legacy). The shared logic (network validation, OVA import, hw version cloning) is extracted into an import_ova_and_clone_hw_versions() function to avoid duplication. - Remove upi-conf-vsphere-ova-vcm ref and directory - Remove upi-conf-vsphere-ova-vcm from 13 chain YAML files - Add vsphere-ibmcloud-ci credentials to consolidated ref.yaml
…ingle step Merge the VCM (vsphere-elastic) and legacy code paths for IPI install-config platform generation into a single script that branches on CLUSTER_PROFILE_NAME. Key differences preserved in the consolidated script: - VCM reads VM specs from vault vm-specs.json; legacy hardcodes - VCM uses dataDisks format with diskSetup; legacy uses additionalDisks - VCM uses platform.yaml from SHARED_DIR for >= 4.13; legacy constructs inline - VCM strips path components from cluster/datastore names for < 4.13 - VCM adds journal forwarding MachineConfig manifests - Legacy supports SIZE_VARIANT 'large'; VCM does not - Remove ipi-conf-vsphere-vcm ref and directory - Remove ipi-conf-vsphere-vcm from 6 chain YAML files - Add DISK_SETUP env var to consolidated ref.yaml
… single step Merge the VCM and legacy diagnostic collection scripts. Shared code (metric lists, HTML/JS dashboard template, sosreport collection) is unified. Path-specific differences are handled via CLUSTER_PROFILE_NAME branching: - VCM iterates platform.json vCenters/portgroups; legacy uses single portgroup - VCM embeds base64 console screenshots in metric JSON and renders in HTML - VCM collects per-node journal logs from log-gather service - VCM reads LEASE files from SHARED_DIR; legacy from volumes/__runtime__/shared - VCM adds VIP/CIDR/NETWORK topology data to HTML summary - VCM supports FORCE_SOS_REPORT env var - VCM adds certificate debugging via curl/openssl - Shared sosreport collection extracted to collect_sosreport() function - VM/host metric collection extracted to collect_vm_and_host_metrics() - Remove ipi-deprovision-vsphere-diags-vcm ref and directory - Remove ipi-deprovision-vsphere-diags-vcm from 4 chain YAML files - Add FORCE_SOS_REPORT env and vsphere-ibmcloud-ci credentials to ref
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
When VSPHERE_ADDITIONAL_CLUSTER is true, the DNS provisioning and deprovisioning steps now create and delete Route53 records for a spoke cluster (hive e2e). The provisioning step also writes additional_cluster.sh with spoke metadata for downstream consumers.
Contributor
|
[REHEARSALNOTIFIER]
A total of 3200 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
|
@jcpowermac: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.