Remove CONFIG variable#73302
Conversation
openshift-ci
Bot
added
the
approved
rsevilla87
force-pushed
the
remove-config
branch
2 times, most recently
from
5decf7e to
7c4691b
Compare
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
rsevilla87
force-pushed
the
remove-config
branch
from
7c4691b to
a17c8f7
Compare
|
/pj-rehearse periodic-ci-openshift-ols-load-generator-main-ols-load-test-10workers |
|
@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
|
[REHEARSALNOTIFIER]
A total of 85 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.22-qe-perfscale-payload-control-plane-6nodes periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-metal-4.19-nightly-x86-daily-virt-6nodes |
|
@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test |
|
@jtaleric: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rsevilla87 while we do not use this var, I do think other teams are using it to point the configs to a URL. |
hm I haven't verified it, I was expecting prow to complain about it :) and it didn't, I'll double check anyway |
|
@rsevilla87: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
/pj-rehearse periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test |
|
@rsevilla87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
@jtaleric: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jtaleric, rsevilla87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Remove CONFIG variable Signed-off-by: Raul Sevilla <rsevilla@redhat.com> * Remove config references Signed-off-by: Raul Sevilla <rsevilla@redhat.com> --------- Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
3 participants
This variable is redundant and not used in the script. Also simplifying the logic a little bit by using the basename command rather than bash variable expansion