Skip to content

HYPERFLEET-369 | Add pre-submit CI jobs for adapter-pull-secret#73291

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
tzhou5:add-adapter-pull-secret-ci
Jan 14, 2026
Merged

HYPERFLEET-369 | Add pre-submit CI jobs for adapter-pull-secret#73291
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
tzhou5:add-adapter-pull-secret-ci

Conversation

@tzhou5
Copy link
Copy Markdown
Contributor

@tzhou5 tzhou5 commented Jan 9, 2026

  • Add ci-operator config with lint, unit, and integration test jobs
  • Configure golangci-lint v2 for Go code quality checks
  • Add unit test job with go mod vendor
  • Add integration test job with nested-podman for testcontainers
  • Add Tide merge configuration
  • Add PROW plugins configuration
  • Add OWNERS files (AlexVulaj removed - left the team)

@openshift-ci openshift-ci Bot requested review from hector-vido and jmguzik January 9, 2026 01:56
@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 9, 2026
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 9, 2026
@tzhou5 tzhou5 force-pushed the add-adapter-pull-secret-ci branch from 7a64705 to dc5d7f5 Compare January 9, 2026 02:27
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 9, 2026
@tzhou5 tzhou5 force-pushed the add-adapter-pull-secret-ci branch from dc5d7f5 to 35c49e7 Compare January 9, 2026 02:59
@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 9, 2026

/pj-rehearse pull-ci-openshift-hyperfleet-adapter-pull-secret-main-images pull-ci-openshift-hyperfleet-adapter-pull-secret-main-integration pull-ci-openshift-hyperfleet-adapter-pull-secret-main-lint pull-ci-openshift-hyperfleet-adapter-pull-secret-main-unit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 9, 2026

@tzhou5: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 12, 2026

/retest

@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 12, 2026

/retest ci/rehearse/openshift-hyperfleet/adapter-pull-secret/main/lint

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 12, 2026

@tzhou5: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test app-ci-config-dry

/test boskos-config

/test boskos-config-generation

/test build01-dry

/test build02-dry

/test build03-dry

/test build04-dry

/test build06-dry

/test build07-dry

/test build08-dry

/test build09-dry

/test build10-dry

/test check-gh-automation

/test check-gh-automation-tide

/test ci-operator-config

/test ci-operator-config-metadata

/test ci-operator-registry

/test ci-secret-bootstrap-config-validation

/test ci-testgrid-allow-list

/test clusterimageset-validate

/test config

/test core-valid

/test generated-config

/test generated-dashboards

/test hosted-mgmt-dry

/test image-mirroring-config-validation

/test jira-lifecycle-config

/test labels

/test openshift-image-mirror-mappings

/test ordered-prow-config

/test owners

/test pr-reminder-config

/test prow-config

/test prow-config-filenames

/test prow-config-semantics

/test pylint

/test release-config

/test release-controller-config

/test rover-groups-config-validation

/test secret-generator-config-valid

/test services-valid

/test stackrox-stackrox-stackrox-stackrox-check

/test step-registry-metadata

/test step-registry-shellcheck

/test sync-rover-groups

/test verified-config

/test vsphere02-dry

/test yamllint

The following commands are available to trigger optional jobs:

/test build05-dry

/test build11-dry

/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation

pull-ci-openshift-release-check-gh-automation-tide

pull-ci-openshift-release-master-boskos-config-generation

pull-ci-openshift-release-master-ci-operator-config

pull-ci-openshift-release-master-ci-operator-config-metadata

pull-ci-openshift-release-master-ci-operator-registry

pull-ci-openshift-release-master-config

pull-ci-openshift-release-master-core-valid

pull-ci-openshift-release-master-generated-config

pull-ci-openshift-release-master-ordered-prow-config

pull-ci-openshift-release-master-owners

pull-ci-openshift-release-master-prow-config

pull-ci-openshift-release-master-prow-config-filenames

pull-ci-openshift-release-master-prow-config-semantics

pull-ci-openshift-release-master-release-controller-config

pull-ci-openshift-release-openshift-image-mirror-mappings

pull-ci-openshift-release-yamllint
Details

In response to this:

/retest ci/rehearse/openshift-hyperfleet/adapter-pull-secret/main/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 12, 2026

/retest

@openshift-ci openshift-ci Bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 12, 2026
@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 12, 2026

/pj-rehearse pull-ci-openshift-hyperfleet-adapter-pull-secret-main-images pull-ci-openshift-hyperfleet-adapter-pull-secret-main-integration pull-ci-openshift-hyperfleet-adapter-pull-secret-main-lint pull-ci-openshift-hyperfleet-adapter-pull-secret-main-unit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 12, 2026

@tzhou5: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 12, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 12, 2026

@tzhou5: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 12, 2026
yingzhanredhat
yingzhanredhat reviewed Jan 13, 2026
View reviewed changes
Comment thread ci-operator/config/openshift-hyperfleet/adapter-pull-secret/OWNERS
# If the repo had OWNERS_ALIASES then the aliases were expanded
# Logins who are not members of 'openshift' organization were filtered out
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md

Copy link
Copy Markdown
Contributor

@yingzhanredhat yingzhanredhat Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is generated automatically.Do you copy it manually?

Copy link
Copy Markdown
Contributor Author

@tzhou5 tzhou5 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is generated automatically.

yingzhanredhat
yingzhanredhat reviewed Jan 13, 2026
View reviewed changes
Comment thread .../openshift-hyperfleet/adapter-pull-secret/openshift-hyperfleet-adapter-pull-secret-main.yaml Outdated
make test
container:
from: src
- as: integration
Copy link
Copy Markdown
Contributor

@yingzhanredhat yingzhanredhat Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other repos,we put int and unit test in main.yaml. and integration test to __presubmit.yaml

Copy link
Copy Markdown
Contributor Author

@tzhou5 tzhou5 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, add a new file named __presubmit.yaml

yingzhanredhat
yingzhanredhat reviewed Jan 13, 2026
View reviewed changes
Comment thread core-services/prow/02_config/openshift-hyperfleet/adapter-pull-secret/_pluginconfig.yaml Outdated
@@ -0,0 +1,76 @@
approve:
- commandHelpLink: ""
Copy link
Copy Markdown
Contributor

@yingzhanredhat yingzhanredhat Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It missed lgtm_acts_as_approve config.

Copy link
Copy Markdown
Contributor Author

@tzhou5 tzhou5 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 13, 2026
@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 13, 2026

/pj-rehearse pull-ci-openshift-hyperfleet-adapter-pull-secret-main-images pull-ci-openshift-hyperfleet-adapter-pull-secret-main-integration pull-ci-openshift-hyperfleet-adapter-pull-secret-main-lint pull-ci-openshift-hyperfleet-adapter-pull-secret-main-unit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2026

@tzhou5: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2026

@tzhou5: job(s): pull-ci-openshift-hyperfleet-adapter-pull-secret-main-images, pull-ci-openshift-hyperfleet-adapter-pull-secret-main-integration either don't exist or were not found to be affected, and cannot be rehearsed

@tzhou5 tzhou5 force-pushed the add-adapter-pull-secret-ci branch from 0b486ee to 2a8fc84 Compare January 13, 2026 03:58
@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 13, 2026

/pj-rehearse pull-ci-openshift-hyperfleet-adapter-pull-secret-main-lint pull-ci-openshift-hyperfleet-adapter-pull-secret-main-presubmits-images pull-ci-openshift-hyperfleet-adapter-pull-secret-main-presubmits-integration pull-ci-openshift-hyperfleet-adapter-pull-secret-main-unit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2026

@tzhou5: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tzhou5 tzhou5 force-pushed the add-adapter-pull-secret-ci branch 2 times, most recently from dedca90 to 8d76490 Compare January 13, 2026 04:31
@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 13, 2026

/pj-rehearse pull-ci-openshift-hyperfleet-adapter-pull-secret-main-lint pull-ci-openshift-hyperfleet-adapter-pull-secret-main-presubmits-images pull-ci-openshift-hyperfleet-adapter-pull-secret-main-presubmits-integration pull-ci-openshift-hyperfleet-adapter-pull-secret-main-unit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2026

@tzhou5: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tzhou5 tzhou5 force-pushed the add-adapter-pull-secret-ci branch from 8d76490 to 6bf22d5 Compare January 13, 2026 04:57
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2026

[REHEARSALNOTIFIER]
@tzhou5: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hyperfleet-adapter-pull-secret-main-lint openshift-hyperfleet/adapter-pull-secret presubmit Presubmit changed
pull-ci-openshift-hyperfleet-adapter-pull-secret-main-presubmits-images openshift-hyperfleet/adapter-pull-secret presubmit Presubmit changed
pull-ci-openshift-hyperfleet-adapter-pull-secret-main-presubmits-integration openshift-hyperfleet/adapter-pull-secret presubmit Presubmit changed
pull-ci-openshift-hyperfleet-adapter-pull-secret-main-unit openshift-hyperfleet/adapter-pull-secret presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 13, 2026

/pj-rehearse pull-ci-openshift-hyperfleet-adapter-pull-secret-main-lint pull-ci-openshift-hyperfleet-adapter-pull-secret-main-presubmits-images pull-ci-openshift-hyperfleet-adapter-pull-secret-main-presubmits-integration pull-ci-openshift-hyperfleet-adapter-pull-secret-main-unit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2026

@tzhou5: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 13, 2026

/retest

@yingzhanredhat
Copy link
Copy Markdown
Contributor

yingzhanredhat commented Jan 13, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tzhou5, yingzhanredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tzhou5
Copy link
Copy Markdown
Contributor Author

tzhou5 commented Jan 14, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 14, 2026

@tzhou5: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 14, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 4ee8165 into openshift:master Jan 14, 2026
21 of 22 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 14, 2026

@tzhou5: Updated the following 2 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-hyperfleet-adapter-pull-secret-_pluginconfig.yaml using file core-services/prow/02_config/openshift-hyperfleet/adapter-pull-secret/_pluginconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-hyperfleet-adapter-pull-secret-_prowconfig.yaml using file core-services/prow/02_config/openshift-hyperfleet/adapter-pull-secret/_prowconfig.yaml
Details

In response to this:

  • Add ci-operator config with lint, unit, and integration test jobs
  • Configure golangci-lint v2 for Go code quality checks
  • Add unit test job with go mod vendor
  • Add integration test job with nested-podman for testcontainers
  • Add Tide merge configuration
  • Add PROW plugins configuration
  • Add OWNERS files (AlexVulaj removed - left the team)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tzhou5 tzhou5 deleted the add-adapter-pull-secret-ci branch January 14, 2026 02:52
dhensel-rh pushed a commit to dhensel-rh/release that referenced this pull request Feb 19, 2026
@tzhou5 @dhensel-rh
HYPERFLEET-369 | Add pre-submit CI jobs for adapter-pull-secret (open…
d9caea7 
…shift#73291)

* HYPERFLEET-369 | Add pre-submit CI jobs for adapter-pull-secret

* remove untrusted users refer to ci bot

* Address review comments for adapter-pull-secret CI

* fix the error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hector-vido hector-vido Awaiting requested review from hector-vido

@jmguzik jmguzik Awaiting requested review from jmguzik

1 more reviewer

@yingzhanredhat yingzhanredhat yingzhanredhat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yingzhanredhat yingzhanredhat

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tzhou5 @openshift-ci-robot @yingzhanredhat