Skip to content

TRT-2689: Add verify-apm to the verify target #31379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smg247 wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −4
Open

TRT-2689: Add verify-apm to the verify target #31379

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1b0e9d
Re-add verify-apm to the verify target
smg247 Jul 10, 2026
4f596d1
Declare verify as .PHONY in the Makefile
smg247 Jul 10, 2026
d241cca
Disable uv cache in CI to avoid permission errors
smg247 Jul 10, 2026
2f7990e
Use /tmp for uv cache and tool dirs in CI
smg247 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ verify-origin:
hack/verify-jsonformat.sh
hack/verify-generated.sh
hack/verify-tls-ownership.sh
.PHONY: verify-origin
verify: verify-origin
.PHONY: verify-origin verify
verify: verify-origin verify-apm
Comment thread
coderabbitai[bot] marked this conversation as resolved.

# Update all generated artifacts.
#
Expand Down Expand Up @@ -114,9 +114,10 @@ test: test-tools
$(call add-bindata,bindata,-ignore ".*\.(go|md)$$$$" examples/db-templates examples/image-streams examples/sample-app examples/quickstarts/... examples/hello-openshift examples/jenkins/... examples/quickstarts/cakephp-mysql.json test/extended/testdata/... e2echart,testextended,testdata,test/extended/testdata/bindata.go)

# Requires uv (installed in devcontainer). Regenerates CLAUDE.md, AGENTS.md, etc.
_uvx_env = $(if $(filter true,$(CI)),UV_CACHE_DIR=/tmp/uv-cache UV_TOOL_DIR=/tmp/uv-tools)
apm:
uvx --from apm-cli@0.13.0 apm install
uvx --from apm-cli@0.13.0 apm compile
$(_uvx_env) uvx --from apm-cli@0.13.0 apm install
$(_uvx_env) uvx --from apm-cli@0.13.0 apm compile
.PHONY: apm

verify-apm: apm
Expand Down