OCPEDGE-2785: fix: adjusting DaemonSet test to dynamically compute expected pod count

[fracappa]

The expected pod count was hardcoded to 2. This PR introduces a dynamic counting of non-arbiter nodes which avoids failures on clusters with different node counts, and prevents double counting nodes that carry both control-plane and worker labels.

Summary by CodeRabbit

• Bug Fixes
  • Improved highly available arbiter deployment checks to account for the number of schedulable cluster nodes.
  • DaemonSet pod validation now waits for and verifies the correct number of running pods while continuing to exclude arbiter nodes.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@fracappa: This pull request explicitly references no jira issue.

Details

In response to this:

The expected pod count was hardcoded to 2. This PR introduces a dynamic counting of non-arbiter nodes which avoids failures on clusters with different node counts, and prevents double counting nodes that carry both control-plane and worker labels.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

The arbiter topology test now computes the expected DaemonSet pod count from total nodes minus Arbiter-labeled nodes, waits for that count of running pods, and asserts the result while retaining the existing placement check.

Changes

Arbiter DaemonSet validation

Layer / File(s)	Summary
Dynamic schedulable-node expectations test/extended/edge_topologies/arbiter_topology.go	The test derives schedulableNodes from cluster node counts and validates that the DaemonSet has the corresponding number of running pods, while preserving the Arbiter placement assertion.

Estimated code review effort: 2 (Simple) | ~5 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@fracappa: This pull request references OCPEDGE-2785 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target only the "5.0.0" version, but multiple target versions were set.

Details

In response to this:

The expected pod count was hardcoded to 2. This PR introduces a dynamic counting of non-arbiter nodes which avoids failures on clusters with different node counts, and prevents double counting nodes that carry both control-plane and worker labels.

Summary by CodeRabbit

• Bug Fixes
• Improved highly available arbiter deployment checks to account for the number of schedulable cluster nodes.
• DaemonSet pod validation now waits for and verifies the correct number of running pods while continuing to exclude arbiter nodes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@fracappa: This pull request references OCPEDGE-2785 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-metal-ovn-two-node-arbiter
/test e2e-metal-ovn-two-node-fencing
/test e2e-metal-ovn-two-node-fencing-recovery

[openshift-ci]

@fracappa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-microshift	33f01a2	link	true	/test e2e-aws-ovn-microshift
ci/prow/e2e-gcp-ovn	33f01a2	link	true	/test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-microshift-serial	33f01a2	link	true	/test e2e-aws-ovn-microshift-serial
ci/prow/e2e-vsphere-ovn	33f01a2	link	true	/test e2e-vsphere-ovn
ci/prow/e2e-metal-ovn-two-node-fencing	33f01a2	link	false	/test e2e-metal-ovn-two-node-fencing
ci/prow/e2e-metal-ovn-two-node-fencing-recovery	33f01a2	link	false	/test e2e-metal-ovn-two-node-fencing-recovery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[fracappa]

/retest-require

[eggfoobar]

/retest-required
/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-arbiter-upgrade-day-2-workers

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-arbiter-upgrade-day-2-workers

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f69bd930-7c76-11f1-82b9-62508ac78c39-0

[eggfoobar]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, fracappa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/edge_topologies/OWNERS [eggfoobar,fracappa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eggfoobar]

/retest-required
/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-arbiter-upgrade-day-2-workers

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-arbiter-upgrade-day-2-workers

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/540804a0-7cc1-11f1-8bf3-726927b3a1b7-0

[eggfoobar]

/payload-aggregate periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-arbiter-upgrade-day-2-workers 3

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-arbiter-upgrade-day-2-workers

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3cdbcbd0-7d71-11f1-8e5a-1970f8ac3fe4-0

[eggfoobar]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-arbiter-upgrade-day-2-workers

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-arbiter-upgrade-day-2-workers

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/93a30b00-7d8e-11f1-807b-0619b9dc111a-0