OCPBUGS-97965: oc adm inspect test fails due to partial pod log collection errors in…

[xueqzhan]

… openshift-multus namespace

Summary by CodeRabbit

• Tests
  • Enhanced oc adm inspect coverage for --since and --since-time filtering, including valid RFC3339 time handling.
  • Confirmed that non-zero results from partial log collection are tolerated when the time is valid, while still verifying gathered log timestamps.
  • Ensured invalid time values continue to fail with the expected --since-time RFC3339 error message.
  • Updated inspection scenarios to target a different cluster target for more robust validation.

[openshift-ci-robot]

@xueqzhan: This pull request references Jira Issue OCPBUGS-97965, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

… openshift-multus namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

The oc adm inspect must-gather tests now tolerate partial collection errors for valid --since-time input and use ns/openshift-console as the inspect target across since and since-time cases.

Changes

Must-gather inspect flag validation

Layer / File(s)	Summary
Inspect flag validation and error handling test/extended/cli/mustgather.go	Uses Output() for valid --since-time handling, rejects RFC3339 errors, preserves timestamp validation, and changes related inspect targets to ns/openshift-console.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5 | ❌ 10

❌ Failed checks (10 inconclusive)

Check name	Status	Explanation	Resolution
Stable And Deterministic Test Names	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Weak-Crypto	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is clearly related to the main change: fixing oc adm inspect test failures caused by partial pod log collection errors.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[xueqzhan]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-ipv4

[openshift-ci]

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-ipv4

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b6602750-7a3b-11f1-8bc9-2413df6f411b-0

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [xueqzhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xueqzhan]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-dualstack

[openshift-ci]

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-dualstack

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d7f6c950-7a3b-11f1-872c-ed196ab572c3-0

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[xueqzhan]

/payload-job /payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ipi-ovn-ipv4

[openshift-ci]

@xueqzhan: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@xueqzhan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-fips	f10c7fc	link	true	/test e2e-aws-ovn-fips
ci/prow/e2e-aws-csi	f10c7fc	link	true	/test e2e-aws-csi
ci/prow/e2e-gcp-csi	f10c7fc	link	true	/test e2e-gcp-csi
ci/prow/e2e-aws-ovn-serial-2of2	f10c7fc	link	true	/test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-ovn-microshift-serial	f10c7fc	link	true	/test e2e-aws-ovn-microshift-serial
ci/prow/e2e-vsphere-ovn-upi	f10c7fc	link	true	/test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-ovn-serial-1of2	f10c7fc	link	true	/test e2e-aws-ovn-serial-1of2
ci/prow/e2e-gcp-ovn	f10c7fc	link	true	/test e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-upgrade	f10c7fc	link	true	/test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-microshift	f10c7fc	link	true	/test e2e-aws-ovn-microshift
ci/prow/e2e-metal-ipi-ovn-ipv6	f10c7fc	link	true	/test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.