Skip to content

OCPBUGS-97822: Wait for DNS before running http2 tests#31368

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
gcs278:fix-http2-test-dns-resolution
Jul 8, 2026
Merged

OCPBUGS-97822: Wait for DNS before running http2 tests#31368
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
gcs278:fix-http2-test-dns-resolution

Conversation

@gcs278

@gcs278 gcs278 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add an explicit DNS resolution step with a 10-minute timeout before running the HTTP/2 test cases, matching the pattern already used in h2spec.go
  • Without this, the test starts HTTP requests immediately after the IngressController becomes available and burns poll iterations on DNS failures until the shard domain propagates

Example Failure

DNS timeout causing test failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_router/792/pull-ci-openshift-router-master-e2e-aws-fips/2074206177318670336

🤖 Generated with Claude Code

Add an explicit DNS resolution step with a 10-minute timeout before
running the HTTP/2 test cases, matching the pattern used in h2spec.go.
Without this, the test starts HTTP requests immediately after the
IngressController becomes available and burns poll iterations on DNS
failures until the shard domain propagates.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8d7abe90-932d-4802-a6c3-f8b5a16f39b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@gcs278 gcs278 changed the base branch from release-5.0 to main July 7, 2026 00:07
@openshift-ci openshift-ci Bot requested review from grzpiotrowski and rfredette July 7, 2026 00:08
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2026
@gcs278 gcs278 changed the title test/extended/router: wait for DNS before running http2 tests OCPBUGS-97822: test/extended/router: wait for DNS before running http2 tests Jul 7, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@gcs278: This pull request references Jira Issue OCPBUGS-97822, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Add an explicit DNS resolution step with a 10-minute timeout before running the HTTP/2 test cases, matching the pattern already used in h2spec.go
  • Without this, the test starts HTTP requests immediately after the IngressController becomes available and burns poll iterations on DNS failures until the shard domain propagates

Example Failure

DNS timeout causing test failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_router/792/pull-ci-openshift-router-master-e2e-aws-fips/2074206177318670336

Test plan

  • Verify the http2 conformance test passes on AWS clusters
  • Verify no regression on Azure/GCP

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278 gcs278 changed the title OCPBUGS-97822: test/extended/router: wait for DNS before running http2 tests OCPBUGS-97822: Wait for DNS before running http2 tests Jul 7, 2026
@openshift-ci openshift-ci Bot requested a review from melvinjoseph86 July 7, 2026 00:08
@gcs278

gcs278 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/close

@openshift-ci openshift-ci Bot closed this Jul 7, 2026
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@gcs278: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot

Copy link
Copy Markdown

@gcs278: This pull request references Jira Issue OCPBUGS-97822. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Add an explicit DNS resolution step with a 10-minute timeout before running the HTTP/2 test cases, matching the pattern already used in h2spec.go
  • Without this, the test starts HTTP requests immediately after the IngressController becomes available and burns poll iterations on DNS failures until the shard domain propagates

Example Failure

DNS timeout causing test failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_router/792/pull-ci-openshift-router-master-e2e-aws-fips/2074206177318670336

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278

gcs278 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/reopen

@openshift-ci openshift-ci Bot reopened this Jul 7, 2026
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@gcs278: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot

Copy link
Copy Markdown

@gcs278: This pull request references Jira Issue OCPBUGS-97822, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Add an explicit DNS resolution step with a 10-minute timeout before running the HTTP/2 test cases, matching the pattern already used in h2spec.go
  • Without this, the test starts HTTP requests immediately after the IngressController becomes available and burns poll iterations on DNS failures until the shard domain propagates

Example Failure

DNS timeout causing test failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_router/792/pull-ci-openshift-router-master-e2e-aws-fips/2074206177318670336

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkowalski

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gcs278

gcs278 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

I think we can move forward with this - need CI to add /verified by CI:

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@gcs278

gcs278 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/test okd-scos-images

@gcs278

gcs278 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

not related
/retest

@melvinjoseph86

Copy link
Copy Markdown
Contributor

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@melvinjoseph86: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@melvinjoseph86

Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit da416b0 into openshift:main Jul 8, 2026
21 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@gcs278: Jira Issue OCPBUGS-97822: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-97822 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Summary

  • Add an explicit DNS resolution step with a 10-minute timeout before running the HTTP/2 test cases, matching the pattern already used in h2spec.go
  • Without this, the test starts HTTP requests immediately after the IngressController becomes available and burns poll iterations on DNS failures until the shard domain propagates

Example Failure

DNS timeout causing test failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_router/792/pull-ci-openshift-router-master-e2e-aws-fips/2074206177318670336

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants