Skip to content

terminationmessagepolicy: correctly fail on violations#30993

Draft
sosiouxme wants to merge 2 commits intoopenshift:mainfrom
sosiouxme:20260409-TRT-2084-terminationMessage-checker
Draft

terminationmessagepolicy: correctly fail on violations#30993
sosiouxme wants to merge 2 commits intoopenshift:mainfrom
sosiouxme:20260409-TRT-2084-terminationMessage-checker

Conversation

@sosiouxme
Copy link
Copy Markdown
Member

@sosiouxme sosiouxme commented Apr 9, 2026

No description provided.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot bot commented Apr 9, 2026

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1f05cf9b-a85d-44c9-b95d-71bc64151595

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2026
@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Apr 9, 2026

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-csi
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-csi
/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-csi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

@sosiouxme: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-csi
  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-csi
  • periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4f1c41c0-3461-11f1-8ec6-3f26cee3bd17-0

@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Apr 10, 2026

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@sosiouxme: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1ebda420-34f6-11f1-888e-44f9bcdaa466-0

@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Apr 10, 2026

relatively quick job with one common violation openshift-insights:
/payload-job periodic-ci-openshift-csi-operator-release-4.22-periodics-periodic-e2e-azure-file-csi
a bit longer with disparate violations:
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-single-node-disruptive-longrunning-techpreview-2of2
longer still with 4 including cnv and frr
/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@sosiouxme: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-csi-operator-release-4.22-periodics-periodic-e2e-azure-file-csi
  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-single-node-disruptive-longrunning-techpreview-2of2
  • periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/70e21f20-3527-11f1-8767-1aff209ce180-0

@sosiouxme
terminationmessagepolicy: add temporary exemptions
d381637 
These have crept in while the test was erroneously allowed to flake.
See https://redhat.atlassian.net/browse/TRT-2084
We will continue to flake them while working to eradicate them.
Meanwhile, new ones should be hard failures.
@sosiouxme
Copy link
Copy Markdown
Member Author

sosiouxme commented Apr 10, 2026

Trigger the same jobs but with the exemptions added.
/payload-job periodic-ci-openshift-csi-operator-release-4.22-periodics-periodic-e2e-azure-file-csi
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-single-node-disruptive-longrunning-techpreview-2of2
/payload-job periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@sosiouxme: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-csi-operator-release-4.22-periodics-periodic-e2e-azure-file-csi
  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-single-node-disruptive-longrunning-techpreview-2of2
  • periodic-ci-openshift-ovn-kubernetes-release-4.22-periodics-e2e-metal-ipi-ovn-bgp-virt-ipv4-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0439ee40-352a-11f1-8e7c-d36a2f481082-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sosiouxme