OCPEDGE-2381: Verify etc pod should start with oom_score_adj as system-node-critical#30982
OCPEDGE-2381: Verify etc pod should start with oom_score_adj as system-node-critical#30982kasturinarra wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@kasturinarra: This pull request references OCPEDGE-2381 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis pull request adds test coverage for OOM score verification in an etcd topology suite. New constants define shell commands to read the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/extended/two_node/tnf_topology.go (1)
20-20: Remove or clarify thepcs resource describecheck—it validates agent defaults, not cluster configurationLines 147-150 check the resource agent's metadata (what parameters the agent supports), not the cluster's configured etcd resource. For cluster configuration validation, use
pcs resource show podman-etcdinstead, or remove this check entirely since lines 152-158 already validate the actual running process OOM score, which is the authoritative source.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@test/extended/two_node/tnf_topology.go` at line 20, The constant getPcsEtcdOOMDefault and its use performs "pcs resource describe ocf:heartbeat:podman-etcd", which inspects the agent metadata (agent defaults) rather than the cluster's configured resource; update the test to validate cluster configuration by replacing that check with a "pcs resource show podman-etcd" query (or remove the check entirely) and ensure subsequent assertions use the actual resource output or the running process OOM validation already present in the test (keep the existing OOM score verification logic intact).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@test/extended/two_node/tnf_topology.go`:
- Line 20: The constant getPcsEtcdOOMDefault and its use performs "pcs resource
describe ocf:heartbeat:podman-etcd", which inspects the agent metadata (agent
defaults) rather than the cluster's configured resource; update the test to
validate cluster configuration by replacing that check with a "pcs resource show
podman-etcd" query (or remove the check entirely) and ensure subsequent
assertions use the actual resource output or the running process OOM validation
already present in the test (keep the existing OOM score verification logic
intact).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8f698dc0-86b4-426d-b9b5-6eb99a99da26
📒 Files selected for processing (1)
test/extended/two_node/tnf_topology.go
|
Scheduling required tests: |
|
@kasturinarra: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-vsphere-ovn |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview |
|
@kasturinarra: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7219aa10-343d-11f1-97d2-24b0cfb9abc2-0 |
openshift-ci-robot
added
the
verified
|
@kasturinarra: This PR has been marked as verified by DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve Nit: can we use the constant whenever -997 appears? It feels weird to me to have to check all of these values if ever this baseline value were to change. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypoulz, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
3 participants
No description provided.