OCPBUGS-82070: Skip machine scale test when bare metal lacks extra workers.

[RadekManak]

Treat bare-metal extra-worker data as a hard precondition so fixed-capacity clusters skip cleanly instead of timing out on impossible MachineSet scale-ups.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@RadekManak: This pull request references Jira Issue OCPBUGS-82070, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Treat bare-metal extra-worker data as a hard precondition so fixed-capacity clusters skip cleanly instead of timing out on impossible MachineSet scale-ups.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dcb3da7f-4df7-41bc-a9a1-fc4ca1fa8fcc

📥 Commits

Reviewing files that changed from the base of the PR and between c4e9153 and 5487a06.

📒 Files selected for processing (3)

• test/extended/baremetal/helper.go
• test/extended/etcd/helpers/helpers.go
• test/extended/machines/scale.go

---

Walkthrough

The tests update baremetal-related control flow: configClient is created earlier, the cluster infrastructure is retrieved to check infrastructure.Status.Platform, and calls that deploy extra workers are now gated by platform and by CanDeployExtraWorkers() which returns (bool, error), with skips on unavailable cases.

Changes

Cohort / File(s)	Summary
Machines test test/extended/machines/scale.go	Move configClient initialization earlier; fetch Infrastructure via configClient.ConfigV1().Infrastructures().Get(...); use infrastructure.Status.Platform to gate baremetal logic; skip test with e2eskipper.Skipf() when extra-worker deployment is unavailable; removed duplicate configClient re-init.
Baremetal helper API test/extended/baremetal/helper.go	Change CanDeployExtraWorkers() signature to return (bool, error); treat missing extraworkers-secret as non-error (return false, nil) and return errors for other failures.
Etcd test helpers test/extended/etcd/helpers/helpers.go	Update call-site to handle CanDeployExtraWorkers()'s (bool, error) return: capture err, assert no error, then conditionally run helper.Setup() and helper.DeployExtraWorker(0).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RadekManak
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RadekManak]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-serial-techpreview-3of3

[openshift-ci]

@RadekManak: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-serial-techpreview-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/037e8d40-3358-11f1-892c-7f136bb7f0bb-0

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/extended/machines/scale.go`:
- Around line 232-235: CanDeployExtraWorkers() currently masks all secret-read
errors as false, causing transient API/RBAC failures to be treated as skips;
change its signature to return (bool, error) (or add a helper that returns
error) and update its implementation in test/extended/baremetal/helper.go to
return (false, err) only on real read errors and (false, nil) only when the
extraworkers-secret is actually NotFound; then update the caller in
test/extended/machines/scale.go (where helper.CanDeployExtraWorkers() is
invoked) to check the error: if err == nil && ok == false -> Skipf (secret
absent), if err != nil -> propagate/fail the test with the underlying error (do
not Skip), and if ok == true -> continue. Ensure log/skip messages still
reference the secret presence case and preserve the original error when failing.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f575daa2-da36-4161-aad2-ed68c432d45c

📥 Commits

Reviewing files that changed from the base of the PR and between ff6f2ef and c4e9153.

📒 Files selected for processing (1)

• test/extended/machines/scale.go

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[RadekManak]

/jira refresh

[openshift-ci-robot]

@RadekManak: This pull request references Jira Issue OCPBUGS-82070, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-metal-ovn-two-node-fencing

[openshift-ci]

@RadekManak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-fips	5487a06	link	true	/test e2e-aws-ovn-fips
ci/prow/e2e-metal-ovn-two-node-fencing	5487a06	link	false	/test e2e-metal-ovn-two-node-fencing

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.