Skip to content

OPRUN-4468: Add OTE tests for OLMv1 DeploymentConfig support#662

Open
tmshort wants to merge 1 commit intoopenshift:mainfrom
tmshort:config-api-ote
Open

OPRUN-4468: Add OTE tests for OLMv1 DeploymentConfig support#662
tmshort wants to merge 1 commit intoopenshift:mainfrom
tmshort:config-api-ote

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Mar 12, 2026

Add 7 Ginkgo tests under [sig-olmv1][OCPFeatureGate:NewOLMDeploymentConfig] covering the spec.config.inline.deploymentConfig feature:

Positive tests (verify applied customisations):

  • environment variables
  • resource requirements
  • tolerations
  • node selector
  • annotations on deployment and pod template

Negative tests (verify terminal validation errors):

  • invalid deploymentConfig.env type (string instead of array)
  • unknown field inside deploymentConfig (additionalProperties:false)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2026

@tmshort: This pull request references OPRUN-4468 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Add 7 Ginkgo tests under [sig-olmv1][OCPFeatureGate:NewOLMDeploymentConfig] covering the spec.config.inline.deploymentConfig feature:

Positive tests (verify applied customisations):

  • environment variables
  • resource requirements
  • tolerations
  • node selector
  • annotations on deployment and pod template

Negative tests (verify terminal validation errors):

  • invalid deploymentConfig.env type (string instead of array)
  • unknown field inside deploymentConfig (additionalProperties:false)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2026
Add 7 Ginkgo tests under [sig-olmv1][OCPFeatureGate:NewOLMDeploymentConfig]
covering the spec.config.inline.deploymentConfig feature:

Positive tests (verify applied customisations):
- environment variables
- resource requirements
- tolerations
- node selector
- annotations on deployment and pod template

Negative tests (verify terminal validation errors):
- invalid deploymentConfig.env type (string instead of array)
- unknown field inside deploymentConfig (additionalProperties:false)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2026

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-techpreview-olmv1-ext d8f4ab6 link true /test e2e-aws-techpreview-olmv1-ext
ci/prow/openshift-e2e-aws d8f4ab6 link true /test openshift-e2e-aws
ci/prow/e2e-aws-olmv1-ext d8f4ab6 link true /test e2e-aws-olmv1-ext
ci/prow/e2e-aws-upgrade-ovn-single-node d8f4ab6 link false /test e2e-aws-upgrade-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants