OCPDOCS CQA MACH-6: CPMSO Provider Configurations and Health Checks Redux - #117206
OCPDOCS CQA MACH-6: CPMSO Provider Configurations and Health Checks Redux#117206mburke5678 wants to merge 1 commit into
Conversation
|
@mburke5678: No Jira issue with key MACH-6 exists in the tracker at https://redhat.atlassian.net. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
size/L
|
@mburke5678: No Jira issue with key MACH-6 exists in the tracker at https://redhat.atlassian.net. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jeana-redhat
left a comment
jeana-redhat
left a comment
There was a problem hiding this comment.
Wheeeee great work here! TYSM!
|
|
||
| -- | ||
| `metadata.name`:: Specifies the name of the machine health check to deploy. | ||
| `spec.selector.matchLabels`:: Replace the parameters for the following labels: |
There was a problem hiding this comment.
This and it's children a prescriptive ("Replace" and "Specify") rather than descriptive like the rest ("Specifies"). Is there a way to make this list more parallel?
| nodeStartupTimeout: "10m" | ||
| ---- | ||
| + | ||
| where |
There was a problem hiding this comment.
Mix of prescriptive and descriptive sentence construction here, can they be made more consistent?
There was a problem hiding this comment.
For this one, metadata.annotations:: For bare metal clusters, you must include the machine.openshift.io/remediation-strategy: external-baremetal annotation..., this was existing text, which I left as-is because adding this annotation is required for annotation-based remediation. WDYT?
| timeout: "300s" | ||
| ---- | ||
| + | ||
| where: |
There was a problem hiding this comment.
Mix of prescriptive and descriptive sentence construction here, can they be made more consistent?
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
https://redhat.atlassian.net/browse/OSDOCS-17046
Previews:
Deploying machine health checks -- Updated entire assembly.
Changing the RHOSP compute flavor by using a control plane machine set -- Updated module.
Configuring multiple network interface controllers by using machine sets -- Updated module