Open
Conversation
otikhomi
reviewed
Mar 19, 2026
Contributor
There was a problem hiding this comment.
In general, many good suggestions and catches.
But not sure adding a link to the OSD docs to every module is helpful or user-friendly, I mean this:
.Additional resources
- link:https://docs.redhat.com/en/documentation/openshift_dedicated[{product-title} documentation]
Especially when modules are short and an html-single doc will show an OSD docs link every 20-30 lines.
cloud_experts_osd_tutorials/cloud-experts-osd-update-component-routes.adoc
Outdated
Show resolved
Hide resolved
cloud_experts_osd_tutorials/CQA-2.1-Assessment-Report-Component-Routes.md
Outdated
Show resolved
Hide resolved
modules/cloud-experts-osd-limit-egress-ngfw-clean-resources.adoc
Outdated
Show resolved
Hide resolved
modules/cloud-experts-osd-update-component-routes-add-certificates-as-secrets.adoc
Outdated
Show resolved
Hide resolved
modules/cloud-experts-osd-update-component-routes-reset-component-routes-to-default.adoc
Outdated
Show resolved
Hide resolved
f5f4c38 to
675fe3c
Compare
675fe3c to
c1457a7
Compare
|
@EricPonvelle: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s):
enterprise-4.21+Issue:
Link to docs preview:
QE review:
Additional information:
Using the CQA Assessment Toolkit, this PR corrects a lot of the issues within the
Cloud Experts Tutorialsbook for theopenshift-dedicateddistribution.