Skip to content

NO-JIRA: Isolate OCP-42982 kubeconfig writes - #2337

Draft
not-stbenjam wants to merge 1 commit into
openshift:mainfrom
not-stbenjam:agent/isolate-oc-42982-kubeconfig
Draft

NO-JIRA: Isolate OCP-42982 kubeconfig writes#2337
not-stbenjam wants to merge 1 commit into
openshift:mainfrom
not-stbenjam:agent/isolate-oc-42982-kubeconfig

Conversation

@not-stbenjam

@not-stbenjam not-stbenjam commented Aug 1, 2026

Copy link
Copy Markdown

What changed

Pass --skip-config-write when OCP-42982 creates its explicit p42982-1 project. The project is still created, and the test already supplies -n p42982-1 to the subsequent command.

Root cause

openshift-tests runs extension tests concurrently with the same injected KUBECONFIG. OCP-42982 used oc new-project p42982-1 without --skip-config-write, so oc rewrote that shared file to select a context named p42982-1. Other test processes could load the kubeconfig during that update and fail before their test body with either:

invalid configuration: context was not found for specified context: p42982-1/...

or the same error plus cluster has no server defined.

The 5.0 CI stability study found 79 such observations across 72 builds from April 7 through July 24, 2026, spanning AWS, Azure, GCP, and bare metal. Every observed dangling context was named p42982-1, while the victim test varied; the long-running OCP-42982 test overlapped the sampled failures.

Impact

Retained JUnit was streamed for all 72 affected builds. Fifty-seven builds had a passing retry, 15 had at least one unrecovered context failure, and 6 failed Prow jobs had no independent blocking failure. The conservative historical counterfactual is therefore 6 additional green Prow jobs; no aggregate parent is additionally counted because each affected parent retained an unrelated aggregation failure.

Validation

GOTOOLCHAIN=auto GOMAXPROCS=2 go test -p=2 -run '^$' ./test/e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@not-stbenjam: This pull request explicitly references no jira issue.

Details

In response to this:

What changed

Pass --skip-config-write when OCP-42982 creates its explicit p42982-1 project. The project is still created, and the test already supplies -n p42982-1 to the subsequent command.

Root cause

openshift-tests runs extension tests concurrently with the same injected KUBECONFIG. OCP-42982 used oc new-project p42982-1 without --skip-config-write, so oc rewrote that shared file to select a context named p42982-1. Other test processes could load the kubeconfig during that update and fail before their test body with either:

invalid configuration: context was not found for specified context: p42982-1/...

or the same error plus cluster has no server defined.

The 5.0 CI stability study found 69 such non-RT observations across 63 builds from April 7 through July 24, 2026, spanning AWS, Azure, GCP, and bare metal. Every observed dangling context was named p42982-1, while the victim test varied; the long-running OCP-42982 test overlapped the sampled failures.

Impact

Retained JUnit was streamed for all 63 affected builds. Forty-eight builds had a passing retry, 14 had at least one unrecovered context failure, and 6 failed Prow jobs had no independent blocking failure. The conservative historical counterfactual is therefore 6 additional green Prow jobs; no aggregate parent is additionally counted because each affected parent retained an unrelated aggregation failure.

Validation

GOTOOLCHAIN=auto GOMAXPROCS=2 go test -p=2 -run '^$' ./test/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2026
@openshift-ci

openshift-ci Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: not-stbenjam
Once this PR has been reviewed and has the lgtm label, please assign ingvagabund for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Hi @not-stbenjam. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2026
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Walkthrough

The quota test now passes --skip-config-write when it creates project p42982-1.

Changes

Quota test update

Layer / File(s) Summary
Project creation option
test/e2e/cli.go
The quota test adds --skip-config-write to the new-project invocation for p42982-1.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning The OCP-42982 It block has multiple Expect(err).NotTo(HaveOccurred()) assertions without failure messages, which violates the assertion-message requirement. Add meaningful operation-specific messages to each assertion, and fail when quota output lacks the expected units instead of only logging a warning.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only a CLI argument. The affected Ginkgo title remains a static string and contains no runtime-generated value.
Microshift Test Compatibility ✅ Passed The diff changes one argument in an existing OCP-42982 Ginkgo test; it adds no new It, Describe, Context, or When test, so this check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes one command in existing test/e2e/cli.go; it adds no new Ginkgo test, so the SNO multi-node compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only test/e2e/cli.go, adding --skip-config-write to oc new-project; it adds no manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The only change adds --skip-config-write to an oc command inside the OCP-42982 g.It callback; it adds no process-level stdout or logging write.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes one existing OCP-42982 command by adding --skip-config-write; it adds no Ginkgo test or IPv4/external-network dependency, and the test already skips disconnected clusters.
No-Weak-Crypto ✅ Passed The only PR change adds --skip-config-write to an oc new-project test command; it introduces no weak crypto, custom crypto, or secret comparison.
Container-Privileges ✅ Passed The PR changes only a Go CLI argument. It adds no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds --skip-config-write to an existing command; it adds no logging or sensitive value, and the existing username log is unchanged.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: isolating kubeconfig writes for OCP-42982.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants