Skip to content

Fix for OCPBUGS-113514: CVE-2026-18446 - #1184

Open
germanparente wants to merge 1 commit into
openshift:release-4.16from
germanparente:fix-CVE-2026-18446-release-4.16
Open

Fix for OCPBUGS-113514: CVE-2026-18446#1184
germanparente wants to merge 1 commit into
openshift:release-4.16from
germanparente:fix-CVE-2026-18446-release-4.16

Conversation

@germanparente

Copy link
Copy Markdown
Contributor

Summary

  • Bump fast-uri resolution from 3.1.3 to 3.1.5+ (resolved to 3.1.6) to fix CVE-2026-18446
  • fast-uri before 3.1.5 misparses URIs with backslash-based authority introducers, allowing host-based policy bypass

Test plan

  • CI passes (analyze, frontend, images)
  • No functional changes — resolution bump only

🤖 Generated with Claude Code

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@germanparente: This pull request references Jira Issue OCPBUGS-113514, which is invalid:

  • expected Jira Issue OCPBUGS-113514 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Bump fast-uri resolution from 3.1.3 to 3.1.5+ (resolved to 3.1.6) to fix CVE-2026-18446
  • fast-uri before 3.1.5 misparses URIs with backslash-based authority introducers, allowing host-based policy bypass

Test plan

  • CI passes (analyze, frontend, images)
  • No functional changes — resolution bump only

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 139855bf-bc40-4748-b487-690f50955d1a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jgbernalp and zhuje August 25, 2026 19:18
@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente
Once this PR has been reviewed and has the lgtm label, please assign jan--f for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@germanparente

Copy link
Copy Markdown
Contributor Author

4.17 and on are not using fast-uri, hence:

/label jira/skip-dependent-bug-check

@openshift-ci openshift-ci Bot added the jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. label Aug 25, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@germanparente: This pull request references Jira Issue OCPBUGS-113514, which is valid. The bug has been moved to the POST state.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

Summary

  • Bump fast-uri resolution from 3.1.3 to 3.1.5+ (resolved to 3.1.6) to fix CVE-2026-18446
  • fast-uri before 3.1.5 misparses URIs with backslash-based authority introducers, allowing host-based policy bypass

Test plan

  • CI passes (analyze, frontend, images)
  • No functional changes — resolution bump only

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 25, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: German Parente <gparente@redhat.com>
@germanparente
germanparente force-pushed the fix-CVE-2026-18446-release-4.16 branch from ee58c6d to 3113872 Compare August 25, 2026 20:34
@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@germanparente: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/skip-dependent-bug-check Indicates that the referenced Jira bug does not require a dependent bug. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants