CNV-87535: k8s: add orphan AlertRelabelConfig GC

[sradco]

Detect and remove orphan
AlertRelabelConfig resources that no
longer have a matching PrometheusRule,
preventing stale relabel configs from
accumulating.

Depends on #1171,
#1172, and #1173 (read API stack).

Signed-off-by: Shirly Radco sradco@redhat.com
Co-authored-by: AI Assistant noreply@cursor.com

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@sradco: This pull request references CNV-80608 which is a valid jira issue.

Details

In response to this:

Detect and remove orphan
AlertRelabelConfig resources that no
longer have a matching PrometheusRule,
preventing stale relabel configs from
accumulating.

Depends on #1171,
#1172, and #1173 (read API stack).

Signed-off-by: Shirly Radco sradco@redhat.com
Co-authored-by: AI Assistant noreply@cursor.com

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Warning

Review limit reached

Next included review available in 15 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a637cd42-d64d-4606-a8d1-bedf03bd3fca

📥 Commits

Reviewing files that changed from the base of the PR and between 3426f94 and 0d89ed9.

📒 Files selected for processing (41)

• go.mod
• internal/managementrouter/alerts_get.go
• internal/managementrouter/alerts_get_test.go
• internal/managementrouter/health_get.go
• internal/managementrouter/health_get_test.go
• internal/managementrouter/query_filters.go
• internal/managementrouter/query_filters_test.go
• internal/managementrouter/router.go
• internal/managementrouter/rules_get.go
• pkg/alertcomponent/matcher.go
• pkg/k8s/alert_relabel_config_gc.go
• pkg/k8s/alert_relabel_config_gc_test.go
• pkg/k8s/alerting_health.go
• pkg/k8s/client.go
• pkg/k8s/const.go
• pkg/k8s/prometheus_alerts.go
• pkg/k8s/prometheus_rules_types.go
• pkg/k8s/relabeled_rules.go
• pkg/k8s/relabeled_rules_test.go
• pkg/k8s/rule_label_matchers.go
• pkg/k8s/rule_label_matchers_test.go
• pkg/k8s/types.go
• pkg/management/get_alerting_health.go
• pkg/management/get_alerts.go
• pkg/management/get_alerts_test.go
• pkg/management/get_rules.go
• pkg/management/get_rules_test.go
• pkg/management/list_rules.go
• pkg/management/list_rules_test.go
• pkg/management/management_suite_test.go
• pkg/management/testutils/k8s_client_mock.go
• pkg/management/types.go
• pkg/management/update_classification.go
• pkg/metrics/alerts_collector.go
• pkg/metrics/alerts_collector_test.go
• pkg/metrics/leader_election.go
• test/e2e/alerts_effective_metric_test.go
• test/e2e/framework/framework.go
• test/e2e/get_alerts_test.go
• test/e2e/health_test.go
• test/e2e/relabeled_rules_test.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sradco
Once this PR has been reviewed and has the lgtm label, please assign jgbernalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sradco: This pull request references CNV-87535 which is a valid jira issue.

Details

In response to this:

Detect and remove orphan
AlertRelabelConfig resources that no
longer have a matching PrometheusRule,
preventing stale relabel configs from
accumulating.

Depends on #1171,
#1172, and #1173 (read API stack).

Signed-off-by: Shirly Radco sradco@redhat.com
Co-authored-by: AI Assistant noreply@cursor.com

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@sradco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/go-tests	0d89ed9	link	true	/test go-tests
ci/prow/security	0d89ed9	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.