Skip to content

USHIFT-6948: Verify local host name in standard suite#6455

Open
ggiguash wants to merge 1 commit intoopenshift:mainfrom
ggiguash:verify-local-host-name-resolution
Open

USHIFT-6948: Verify local host name in standard suite#6455
ggiguash wants to merge 1 commit intoopenshift:mainfrom
ggiguash:verify-local-host-name-resolution

Conversation

@ggiguash
Copy link
Copy Markdown
Contributor

@ggiguash ggiguash commented Apr 2, 2026

Verify that anaconda correctly sets the host name during kickstart installation.

This PR adds a new test case to the standard1 suite that checks:

  • The hostname is not "localhost" or any variant containing "local"
  • The hostname contains the expected suite name (e.g., "standard"), confirming that the testing framework's VM naming convention was applied by anaconda during kickstart

The existing "Verify local name resolution" test is renamed to "Verify Local Host Name Resolution" for clarity.

Jira: https://redhat.atlassian.net/browse/USHIFT-6948

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 2, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 42ecbb95-2c82-4d10-a737-cbfe06e89368

📥 Commits

Reviewing files that changed from the base of the PR and between 397b4c9 and ff07ca0.

📒 Files selected for processing (1)
  • test/suites/standard1/hostname.robot

Walkthrough

Updated the Robot Framework test suite to restructure hostname verification tests. Modified suite documentation and renamed test cases: replaced "Verify local name resolution" with "Verify Local Host Name" (adds hostname execution and assertion logic), and renamed the mDNS test case to "Verify Local Host Name Resolution".

Changes

Cohort / File(s) Summary
Robot Test Suite
test/suites/standard1/hostname.robot
Updated suite-level documentation and restructured test cases. Renamed "Verify local name resolution" to "Verify Local Host Name" with new hostname command and assertion logic. Renamed existing mDNS test case to "Verify Local Host Name Resolution".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Apr 2, 2026

/test ?

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Apr 2, 2026

/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc-arm-el10
/test e2e-aws-tests-bootc-arm-el9
/test e2e-aws-tests-bootc-el10
/test e2e-aws-tests-bootc-el9

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented Apr 2, 2026

/test ?

@ggiguash ggiguash marked this pull request as ready for review April 2, 2026 17:23
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2026
@openshift-ci openshift-ci Bot requested review from eslutsky and pmtk April 2, 2026 17:23
@kasturinarra
Copy link
Copy Markdown
Contributor

/test e2e-aws-tests-release

@ggiguash
Copy link
Copy Markdown
Contributor Author

/test all

@eggfoobar
Copy link
Copy Markdown
Contributor

/retest-required

@suleymanakbas91
Copy link
Copy Markdown

@ggiguash could you please add a description to the PR explaining briefly why we need this change? As there is no Jira linked, it is difficult to understand the intent.

@ggiguash ggiguash changed the title NO-ISSUE: Verify local host name in standard suite USHIFT-6948: Verify local host name in standard suite May 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 5, 2026

@ggiguash: This pull request references USHIFT-6948 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented May 5, 2026

@ggiguash could you please add a description to the PR explaining briefly why we need this change? As there is no Jira linked, it is difficult to understand the intent.

Created a JIRA story in the CI enhancements epic and linked to the PR.

@suleymanakbas91
Copy link
Copy Markdown

Thank you!

/lgtm
/retest

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented May 6, 2026

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD f33f068 and 2 for PR HEAD ff07ca0 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD c0deac0 and 1 for PR HEAD ff07ca0 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@ggiguash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-release ff07ca0 link true /test e2e-aws-tests-release

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants