USHIFT-6948: Verify local host name in standard suite#6455
USHIFT-6948: Verify local host name in standard suite#6455ggiguash wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@ggiguash: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated the Robot Framework test suite to restructure hostname verification tests. Modified suite documentation and renamed test cases: replaced "Verify local name resolution" with "Verify Local Host Name" (adds hostname execution and assertion logic), and renamed the mDNS test case to "Verify Local Host Name Resolution". Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test ? |
|
/test e2e-aws-tests |
|
/test ? |
|
/test e2e-aws-tests-release |
|
/test all |
|
/retest-required |
|
@ggiguash could you please add a description to the PR explaining briefly why we need this change? As there is no Jira linked, it is difficult to understand the intent. |
|
@ggiguash: This pull request references USHIFT-6948 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Created a JIRA story in the CI enhancements epic and linked to the PR. |
|
Thank you! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by ci |
|
@ggiguash: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Verify that anaconda correctly sets the host name during kickstart installation.
This PR adds a new test case to the
standard1suite that checks:The existing "Verify local name resolution" test is renamed to "Verify Local Host Name Resolution" for clarity.
Jira: https://redhat.atlassian.net/browse/USHIFT-6948