OCPBUGS-71234: Permit z-stream upgrades when custom featureGates are enabled #6083
Conversation
… upgrades add unit test for upgrade validation
openshift-ci-robot
added
jira/valid-reference
|
@copejon: This pull request references Jira Issue OCPBUGS-71234, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@copejon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| "4. Restart MicroShift: sudo systemctl restart microshift", | ||
| "- Roll back MicroShift to version %s, OR\n"+ | ||
| "- Run: sudo microshift-cleanup-data --all\n"+ | ||
| " and remove custom feature gates from /etc/microshift/config.yaml before restarting MicroShift.", |
There was a problem hiding this comment.
I prefer previous version of instruction with number points. From my point of view it's more readable.
| lockFileVer: versionMetadata{Major: 5, Minor: 0, Patch: 0}, | ||
| currentVer: versionMetadata{Major: 4, Minor: 18, Patch: 0}, | ||
| wantErr: true, | ||
| description: "Major version downgrade (5.0.0 -> 4.18.0) should be blocked", |
There was a problem hiding this comment.
I don't know if I've understood this change correctly but these unit tests seems to be wrong or at least misleading because FeatureSet feature does not exist before 4.21 so I wouldn't use versions previous like 4.18 or 4.19. Also, I don't think we should test downgrade paths because they are not supported.
|
Pausing until we have a decision on MicroShift supporting specific tech-preview features /hold |
openshift-ci
bot
added
the
do-not-merge/hold
3 participants
No description provided.