Update Tools Approval Configuration to always Include Config defaulting to tools annotations#1499
Update Tools Approval Configuration to always Include Config defaulting to tools annotations#1499blublinsky wants to merge 1 commit intoopenshift:mainfrom
Conversation
| if cr.Spec.OLSConfig.ToolsApprovalConfig == nil { | ||
| // Use CRD defaults (must match +kubebuilder:default markers in ToolsApprovalConfig) | ||
| approvalType = string(olsv1alpha1.ApprovalTypeToolAnnotations) // CRD default: tool_annotations | ||
| approvalTimeout = 600 // CRD default: 600 |
There was a problem hiding this comment.
it is better we put this 600 value in the constant file and refer it as something like ToolApprovalTimeout
|
the logics are good. just a suggestion about using a constant for the timeout value. |
blublinsky
force-pushed
the
tools-approval-cleanup
branch
from
a4f2ddb to
63e8d56
Compare
openshift-ci
bot
added
the
needs-rebase
…ng to tools annotations Made-with: Cursor
blublinsky
force-pushed
the
tools-approval-cleanup
branch
from
63e8d56 to
533802a
Compare
openshift-ci
bot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raptorsun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@blublinsky: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Description
This PR finalizes the tools approval feature by removing the "not fully supported" warning and making the configuration behavior more predictable.
Key Changes:
Changed default approval type: never → tool_annotations
Updated +kubebuilder: default marker in ToolsApprovalConfig.ApprovalType
Aligns default behavior with the recommended usage pattern
Always generate the tools approval configuration:
Previously: Config omitted when ToolsApprovalConfig was nil
Now: Config is always present with CRD defaults when not specified
Improves predictability for OLS backend consumption
Type of change
Related Tickets & Documents
https://redhat.atlassian.net/browse/OLS-2693
https://redhat.atlassian.net/browse/OLS-2693
Checklist before requesting a review
Testing