Add prodsec-recommended CodeRabbit security rules#16
Open
onmete wants to merge 5 commits into
Open
Conversation
Covers adding an optional tlsCertificate ConfigMap reference to LLMProviderSpec for corporate proxy CA injection into sandbox pods. Co-authored-by: Cursor <cursoragent@cursor.com>
- crd-api.md: Add rule 22 for spec.tlsCertificate ConfigMapReference, add ConfigMapReference to shared types, update LLMProvider config surface - sandbox-execution.md: Add rule 17 for TLS CA bundle injection behavior (ConfigMap mount, init container concatenation, SSL_CERT_FILE, NODE_EXTRA_CA_CERTS), update planned changes - reconciler.md: Add patchTLSCertificate and addInitContainer to module map, update EnsureAgentTemplate description Co-authored-by: Cursor <cursoragent@cursor.com>
Adopts the security configuration from openshift/coderabbit#17 which adds Red Hat Product Security recommended review rules, path-specific security instructions, security scanner tooling, and knowledge base indexing. Adds: - Global review instructions (secrets, crypto, injection, container privileges, sensitive logging, AI attribution) - 18 path-specific security review blocks (injection, web, crypto, containers, K8s/OpenShift, MCP, agents, LLM, supply chain, CI/CD, auth, API gateway, Go, C/C++, database, messaging, model registry) - Security scanners: gitleaks, semgrep, checkov, hadolint, trivy, osvScanner, actionlint, ast-grep - Knowledge base auto-indexing of AGENTS.md, CLAUDE.md, CONTRIBUTING.md - Additional path_filters for node_modules, dist, minified JS, yarn.lock Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Noise reduction — disable defaults that add clutter without value: - in_progress_fortune, suggested_labels, suggested_reviewers, estimate_code_review_effort, related_prs - finishing_touches for docstrings and unit_tests (prevents CodeRabbit from opening follow-up PRs) Useful additions: - language: en-US, early_access: true - tone_instructions: direct and concise, focus on bugs/security - high_level_summary_in_walkthrough: true - enable_prompt_for_ai_agents: true (AI-friendly inline prompts) - knowledge_base.jira: auto (cross-reference Jira issues) - knowledge_base.linked_repositories: sandbox repo for cross-repo dependency awareness - tools: shellcheck, golangci-lint, yamllint (language-specific linters) Co-authored-by: Cursor <cursoragent@cursor.com>
- Use recursive glob patterns (**/node_modules/**, **/dist/**, **/*.min.js, **/yarn.lock) so nested projects are covered - Add Cargo.lock to the supply-chain path_instructions glob alongside Cargo.toml for consistency Co-authored-by: Cursor <cursoragent@cursor.com>
|
@onmete: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Made with Cursor