[release-4.16] OCPBUGS-77299: go mod vendor for 4.16#2615
[release-4.16] OCPBUGS-77299: go mod vendor for 4.16#2615fgallott wants to merge 6 commits intoopenshift:release-4.16from
Conversation
|
@fgallott: This pull request references Jira Issue OCPBUGS-77299, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@bertinatto may you help me review this one? thank you! |
@fgallott there are several non-optional jobs failing. We can't use |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: This pull request references Jira Issue OCPBUGS-77299, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: This pull request references Jira Issue OCPBUGS-77299, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fgallott The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test verify |
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: This pull request references Jira Issue OCPBUGS-77299, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bertinatto I fixed the tests, may you have a look now? |
|
|
||
| function codegen::informers() { | ||
| GO111MODULE=on GOPROXY=off go install \ | ||
| GO111MODULE=on GOFLAGS=-mod=mod go install \ |
There was a problem hiding this comment.
I believe it's safer to use -mod=readonly instead?
There was a problem hiding this comment.
good call, it should be indeed safer! I'll switch all of them to -mod=readonly
| # staging/src/k8s.io/<repo>. For hermetic builds the vendor directory must be | ||
| # exactly what `go mod vendor` produces (no symlinks, no extra files, and | ||
| # modules.txt must not be modified). The go mod vendor command already handles | ||
| # the staging replace directives in go.mod and vendors the imported packages. |
There was a problem hiding this comment.
It's not clear to me how you avoided the problem that the linking fixed. Do you mind explaining that?
There was a problem hiding this comment.
Do I understand correctly that linking was done because go mod vendor doesn't copy files that were not directly imported, like test files?
There was a problem hiding this comment.
yes, you're right. the symlinks existed because go mod vendor only copies imported packages, but the codegen tools expect vendor/k8s.io/<repo> to contain the full source tree (including as you said test packages that aren't directly imported).
I'm not actually avoiding the problem, but simply moving the solution. The symlinks are removed from update-vendor.sh so the vendor directory stays clean for hermetic builds (Konflux requires vendor/ to match exactly what go mod vendor produces). And in update-codegen.sh the symlinks are temporarily recreated before codegen runs, then everything is restored via a trap on EXIT. This way the vendor directory is correct for builds, and codegen still has access to the full staging source trees when it needs them.
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
@fgallott: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@fgallott: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ART can't build openshift-enterprise-hyperkube hermetically, versions openshift-4.16 backwards
The error is the following:
successful build with these changes