Skip to content

UPSTREAM: <carry>: integrate strict cpu reservation and workload partitioning#2609

Open
ffromani wants to merge 1 commit intoopenshift:masterfrom
ffromani:strict-cpu-resv-managed-cpus
Open

UPSTREAM: <carry>: integrate strict cpu reservation and workload partitioning#2609
ffromani wants to merge 1 commit intoopenshift:masterfrom
ffromani:strict-cpu-resv-managed-cpus

Conversation

@ffromani
Copy link
Copy Markdown

@ffromani ffromani commented Mar 4, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

Ensure interoperability between the workload partitioning feature and the strict-cpu-reservation cpumanager policy option

Which issue(s) this PR is related to:

https://issues.redhat.com/browse/OCPBUGS-77659

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

Fix bug which cause kubelet fail to start if the strict-cpu-reservation is enabled with no pods to run

…itioning

The two features have significant overlap in implementation.
Make sure they integrate with each other.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 4, 2026
@ffromani
Copy link
Copy Markdown
Author

ffromani commented Mar 4, 2026

/hold

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ffromani: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2026
@openshift-ci openshift-ci bot requested review from mrunalp and rphillips March 4, 2026 12:43
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ffromani
Once this PR has been reviewed and has the lgtm label, please assign rphillips for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Copy Markdown
Author

ffromani commented Mar 4, 2026

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 5, 2026

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview-serial-2of2 7192f71 link false /test e2e-aws-ovn-techpreview-serial-2of2
ci/prow/e2e-aws-ovn-runc 7192f71 link false /test e2e-aws-ovn-runc
ci/prow/e2e-aws-ovn-hypershift 7192f71 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-techpreview 7192f71 link false /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani
Copy link
Copy Markdown
Author

ffromani commented Mar 5, 2026

/hold cancel
/cc @MarSik

@openshift-ci openshift-ci bot requested a review from MarSik March 5, 2026 14:38
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2026
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2026
@openshift-merge-robot
Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants