Skip to content

AGENT-1522: bump InternalReleaseImage to v1#10620

Open
pawanpinjarkar wants to merge 2 commits into
openshift:mainfrom
pawanpinjarkar:promote-iri-api-2-v1
Open

AGENT-1522: bump InternalReleaseImage to v1#10620
pawanpinjarkar wants to merge 2 commits into
openshift:mainfrom
pawanpinjarkar:promote-iri-api-2-v1

Conversation

@pawanpinjarkar

@pawanpinjarkar pawanpinjarkar commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
  • Chores
    • Updated module dependency configuration to use an alternate source for API dependencies.
    go mod edit -replace=github.com/openshift/api=github.com/pawanpinjarkar/api@pr-2863-branch
    go get github.com/openshift/api
    go mod tidy
    go mod vendor
    

Requires openshift/api#2880

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: This pull request references AGENT-1522 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from andfasano and bfournie June 11, 2026 19:30
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jcpowermac for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

A replace directive is added to go.mod, redirecting the github.com/openshift/api module to a custom fork at github.com/pawanpinjarkar/api with a pinned version identifier.

Changes

Module replacement

Layer / File(s) Summary
Module replacement directive
go.mod
Add a replace directive that redirects github.com/openshift/api imports to github.com/pawanpinjarkar/api at a pinned version for all builds using this go.mod.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references bumping InternalReleaseImage to v1, but the actual change is a go.mod replace directive redirecting github.com/openshift/api to a fork, which doesn't match the stated objective. Update the title to accurately reflect the change: something like 'Replace openshift/api with pawanpinjarkar/api fork' or clarify how this redirect supports the InternalReleaseImage bump.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR adds 184 new test files to the repository, but ZERO of them use Ginkgo testing framework. All test files use standard Go testing (via func Test... and t.Run()), so the Ginkgo test namin...
Test Structure And Quality ✅ Passed PR #10620 changes only go.mod/go.sum (replace directive for openshift/api); no Ginkgo test code (It blocks) was modified, so the test-quality checks are not applicable.
Microshift Test Compatibility ✅ Passed PR commit only updates go.mod (replace openshift/api -> pawanpinjarkar/api). Among changed non-vendor *_test.go files, none contain “ginkgo” or ginkgo/v2—no MicroShift-incompatible Ginkgo e2e tests...
Single Node Openshift (Sno) Test Compatibility ✅ Passed Checked PR HEAD changed non-vendor _test.go/.go for any github.com/onsi/ginkgo or ginkgo. usage: none found, so no new SNO-incompatible multi-node Ginkgo e2e tests were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed PR 10620 only updates go.mod (replace github.com/openshift/api) and related go.sum/vendor API files; no installer manifests/operator/controller scheduling constraints were changed.
Ote Binary Stdout Contract ✅ Passed PR only updates go.mod/go.sum (replace) and vendored openshift/api; representative changed vendor Go files contain no fmt/klog Print/Println/Printf, so no main/suite process-level stdout writes wer...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR diff vs origin/main includes only go.mod/go.sum, images/installer/Dockerfile.ci, and vendored api changes—no new or modified *_test.go/Ginkgo e2e specs, so no IPv4/Internet assumptions to flag.
No-Weak-Crypto ✅ Passed PR appears limited to go.mod/go.sum replace + regenerated openshift/api vendored files; searches of updated vendor code found no md5/sha1/DES/RC4/3DES/Blowfish/ECB usages.
Container-Privileges ✅ Passed PR #10620 modifies only go.mod and go.sum (no container/K8s manifest diffs). No instances of hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation: true found in related YAML under vendor...
No-Sensitive-Data-In-Logs ✅ Passed PR #10620 changes only go.mod (adds a replace for github.com/openshift/api) and go.sum hashes; no application/logging code touched, so no sensitive data logging introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/cc @andfasano @sadasu @bfournie

@openshift-ci openshift-ci Bot requested a review from sadasu June 11, 2026 19:35
@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/api#2880

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@sadasu

sadasu commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

/testwith openshift/installer/main/e2e-agent-compact-ipv4-iso-no-registry openshift/api#2880 openshift/client-go#383

@sadasu

sadasu commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

/retitle WIP: AGENT-1522: bump InternalReleaseImage to v1

The go.mod changes point to Pawan's openshift/api commit.

Also, @pawanpinjarkar while making the next update to the PR, please make sure to put just the go.mod changes in 1 commit and everything else in a 2nd commit.

@openshift-ci openshift-ci Bot changed the title AGENT-1522: bump InternalReleaseImage to v1 WIP: AGENT-1522: bump InternalReleaseImage to v1 Jun 12, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c9993180-6646-11f1-9b81-8f288bc688c1-0

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/79d770f0-665d-11f1-9ef4-6c006290fce7-0

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@andfasano: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/79d6df40-68cf-11f1-9a39-3d80b7114f29-0

@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2026
@pawanpinjarkar pawanpinjarkar changed the title WIP: AGENT-1522: bump InternalReleaseImage to v1 AGENT-1522: bump InternalReleaseImage to v1 Jun 15, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 04689cc link true /test e2e-aws-ovn
ci/prow/unit 04689cc link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadasu

sadasu commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/client-go#383 openshift/assisted-service#10455 openshift-metal/dev-scripts#1912

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@sadasu: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. unable to get pr from github for: openshift-metal/dev-scripts#1912: Get "http://ghproxy/repos/openshift-metal/dev-scripts/pulls/1912": failed to get installation id for org openshift-metal: the github app is not installed in organization openshift-metal

Please contact an administrator to resolve this issue.

@sadasu

sadasu commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/client-go#383 openshift/assisted-service#10455 openshift-metal3/dev-scripts#1912

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@sadasu: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@sadasu

sadasu commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview openshift/client-go#383 openshift/assisted-service#10455 openshift-metal3/dev-scripts#1912 openshift/machine-config-operator#6174

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@sadasu: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@sadasu

sadasu commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

/testwith openshift/installer/main/e2e-agent-compact-ipv4-iso-no-registry openshift/client-go#383 openshift/assisted-service#10455 openshift-metal3/dev-scripts#1912 openshift/machine-config-operator#6174

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/98d24380-68fc-11f1-8717-d92865f52d7f-0

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@andfasano: This PR was included in a payload test run from openshift/client-go#383
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/456c9050-6957-11f1-9bed-3f2ce7c45a9d-0

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@sadasu: This PR was included in a payload test run from openshift/api#2880
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f987e10-69c5-11f1-9875-224b8c1290ff-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants