OCPBUGS-87815: [release-4.21] Add omitempty to vSphere and Nutanix MachinePool slice fields

[chdeshpa-hue]

Summary

Cherry-pick of #10551 to release-4.21.

Adds omitempty to the DataDisks JSON tag on vSphere and Nutanix MachinePool structs, preventing empty slice serialization that causes unknown-field warnings when hive revendors these types and generates install-configs for older payloads.

Fixes: https://issues.redhat.com/browse/OCPBUGS-85509

/cherry-pick-from #10551

Made with Cursor

[openshift-ci-robot]

@chdeshpa-hue: This pull request references Jira Issue OCPBUGS-85509, which is invalid:

• expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "5.0.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-85509 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of #10551 to release-4.21.

Adds omitempty to the DataDisks JSON tag on vSphere and Nutanix MachinePool structs, preventing empty slice serialization that causes unknown-field warnings when hive revendors these types and generates install-configs for older payloads.

Fixes: https://issues.redhat.com/browse/OCPBUGS-85509

/cherry-pick-from #10551

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ca86811d-8f54-4dfd-97e8-c17153fc8484

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rvanderp3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/types/nutanix/OWNERS
• pkg/types/vsphere/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@chdeshpa-hue: This pull request references Jira Issue OCPBUGS-87815, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-87815 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of #10551 to release-4.21.

Adds omitempty to the DataDisks JSON tag on vSphere and Nutanix MachinePool structs, preventing empty slice serialization that causes unknown-field warnings when hive revendors these types and generates install-configs for older payloads.

Fixes: https://issues.redhat.com/browse/OCPBUGS-85509

/cherry-pick-from #10551

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@chdeshpa-hue: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-nutanix-ovn	b07ae5e	link	false	/test e2e-nutanix-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-robot]

Fix included in release 5.0.0-0.nightly-2026-06-08-075337