Skip to content

Comments

OCPBUGS-77160: Add NMStateConfig to BareMetal backup examples#185

Open
michalskrivanek wants to merge 1 commit intoopenshift:mainfrom
michalskrivanek:OCPBUGS-77160
Open

OCPBUGS-77160: Add NMStateConfig to BareMetal backup examples#185
michalskrivanek wants to merge 1 commit intoopenshift:mainfrom
michalskrivanek:OCPBUGS-77160

Conversation

@michalskrivanek
Copy link

@michalskrivanek michalskrivanek commented Feb 23, 2026

complete the examples

Signed-off-by: Michal Skrivanek michal.skrivanek@redhat.com

What this PR does / why we need it

add missing NMStateConfig resource to BareMetal examples

Which issue(s) this PR fixes

Fixes https://issues.redhat.com/browse/OCPBUGS-77160

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Summary by CodeRabbit

  • Documentation
    • Updated example backup configurations for BareMetal deployments to include network state configuration resources in backup snapshots, ensuring more comprehensive data protection.

Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 23, 2026
@openshift-ci-robot
Copy link

@michalskrivanek: This pull request references Jira Issue OCPBUGS-77160, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

complete the examples

Signed-off-by: Michal Skrivanek michal.skrivanek@redhat.com

What this PR does / why we need it

add missing NMStateConfig resource to BareMetal examples

Which issue(s) this PR fixes

Fixes https://issues.redhat.com/browse/OCPBUGS-77160

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e223e9f and 6a200bb.

📒 Files selected for processing (2)
  • examples/BareMetal/03-backup-bm-csi-compatible.yaml
  • examples/BareMetal/03-backup-bm-csi-no-compatible.yaml

Walkthrough

Added nmstateconfig to the includedResources list in two BareMetal backup YAML configuration files. Both files receive identical modifications to expand the scope of resources included in backup operations.

Changes

Cohort / File(s) Summary
BareMetal Backup Configurations
examples/BareMetal/03-backup-bm-csi-compatible.yaml, examples/BareMetal/03-backup-bm-csi-no-compatible.yaml
Added nmstateconfig to the includedResources list in the Backup spec for both CSI-compatible and non-compatible scenarios.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding NMStateConfig to BareMetal backup examples. It directly matches the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The custom check for Stable and Deterministic Test Names is not applicable. The PR adds nmstateconfig to YAML example files. While test files exist, they use standard Go testing.T patterns with table-driven tests, not Ginkgo BDD-style declarations.
Test Structure And Quality ✅ Passed PR modifies only example YAML files without adding or modifying test code, making the test quality check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from devguyio and enxebre February 23, 2026 13:41
@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michalskrivanek
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 23, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

Hi @michalskrivanek. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants