OCPBUGS-77160: Add NMStateConfig to BareMetal backup examples#185
OCPBUGS-77160: Add NMStateConfig to BareMetal backup examples#185michalskrivanek wants to merge 1 commit intoopenshift:mainfrom
Conversation
Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com>
|
@michalskrivanek: This pull request references Jira Issue OCPBUGS-77160, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (2)
WalkthroughAdded Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michalskrivanek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @michalskrivanek. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
complete the examples
Signed-off-by: Michal Skrivanek michal.skrivanek@redhat.com
What this PR does / why we need it
add missing NMStateConfig resource to BareMetal examples
Which issue(s) this PR fixes
Fixes https://issues.redhat.com/browse/OCPBUGS-77160
Checklist
Summary by CodeRabbit