NO_JIRA: chore(dependencies): Update dependencies to be aligned with Hypershift repo by jparrill · Pull Request #184 · openshift/hypershift-oadp-plugin

jparrill · 2026-02-16T08:47:25Z

Apart from the deps bump, also added the .work to the gitignore file

coderabbitai · 2026-02-16T08:47:42Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Updated .gitignore; bumped Go toolchain and many module dependencies in go.mod; updated builder/base images and added build-time flags and RHSM handling in Dockerfiles; refreshed Tekton task bundle references, converted many tasks to matrix-based multi-platform execution, and removed several conditional gates. No public/exported API changes.

Changes

Cohort / File(s)	Summary
Ignore Patterns `\.gitignore`	Re-added `.dccache` (restored newline boundary) and added a new `.work/` ignore entry under an AI section.
Go module manifest `go.mod`	Bumped Go toolchain to `go 1.25.3`; upgraded numerous direct and indirect dependencies (k8s.io/, controller-runtime, sigs.k8s.io/, golang.org/x/*, prometheus, fxamacker/cbor, etc.); updated/added replace directives. No API signature changes.
Docker build images `Dockerfile`, `Dockerfile.oadp`	Updated builder/base image tags to golang-1.25 variants; added ARG/ENV for `CONTAINER_SUB_MANAGER_OFF` and RHSM subscription handling in `Dockerfile.oadp`; adjusted follow_tag annotations. Build flow and final image layout preserved.
Tekton pipelines `.tekton/oadp-hypershift-oadp-plugin-main-*.yaml`, `.tekton/...`	Refreshed many task bundle image references and digests; replaced many when-condition gates with matrix-driven configurations for multi-platform/arch execution; removed legacy gating parameters (e.g., rebuild) and simplified task wiring; added `CONTAINER_SUB_MANAGER_OFF` to build args and updated LABELS/metadata.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-02-16T08:47:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

muraee · 2026-02-16T10:03:41Z

/lgtm

jparrill · 2026-02-18T14:59:32Z

/retest

Now that this got merged:

CNTRLPLANE-2763: bump 4.22 golang builders to 1.25 openshift-eng/ocp-build-data#8980

openshift-ci · 2026-02-18T16:00:21Z

New changes are detected. LGTM label has been removed.

…t repository Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Dockerfile.oadp`:
- Around line 22-23: The final stage still runs "RUN unlink /etc/rhsm-host"
which can fail if the file doesn't exist; change that command to safely remove
the file only if present (e.g., check existence or use a no-error removal) so
the build won't fail, and keep the existing conditional registration line "RUN
if [ -e \"/activation-key/org\" ]; then subscription-manager register --org
$(cat \"/activation-key/org\") --activationkey $(cat
\"/activation-key/activationkey\"); fi" unchanged except ensuring it follows the
safe unlink removal; update the Dockerfile final stage where "unlink
/etc/rhsm-host" appears (the RUN unlink /etc/rhsm-host invocation) to use the
safe removal approach.
- Around line 11-12: The Dockerfile uses unlink /etc/rhsm-host which fails if
the file/symlink is absent; change that RUN step to safely remove the path
(e.g., test for existence or use a no-fail removal) so the build doesn't error,
e.g. replace the unlink invocation with a conditional removal (check -e or -L)
or a force-remove (rm -f) before the subscription-manager register line; keep
the subscription-manager register logic (the RUN that checks /activation-key/org
and calls subscription-manager register) unchanged so the activation-key flow
still executes.

coderabbitai · 2026-02-18T16:47:07Z

Dockerfile.oadp

+RUN unlink /etc/rhsm-host
+RUN if [ -e "/activation-key/org" ]; then subscription-manager register --org $(cat "/activation-key/org") --activationkey $(cat "/activation-key/activationkey"); fi


⚠️ Potential issue | 🟡 Minor

unlink may fail if /etc/rhsm-host does not exist.

The unlink /etc/rhsm-host command will fail with a non-zero exit code if the symlink doesn't exist, breaking builds in environments without RHSM host configuration.

Proposed fix

-RUN unlink /etc/rhsm-host +RUN rm -f /etc/rhsm-host || true

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

RUN unlink /etc/rhsm-host

RUN if [ -e "/activation-key/org" ]; then subscription-manager register --org $(cat "/activation-key/org") --activationkey $(cat "/activation-key/activationkey"); fi

RUN rm -f /etc/rhsm-host || true

RUN if [ -e "/activation-key/org" ]; then subscription-manager register --org $(cat "/activation-key/org") --activationkey $(cat "/activation-key/activationkey"); fi

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@Dockerfile.oadp` around lines 11 - 12, The Dockerfile uses unlink /etc/rhsm-host which fails if the file/symlink is absent; change that RUN step to safely remove the path (e.g., test for existence or use a no-fail removal) so the build doesn't error, e.g. replace the unlink invocation with a conditional removal (check -e or -L) or a force-remove (rm -f) before the subscription-manager register line; keep the subscription-manager register logic (the RUN that checks /activation-key/org and calls subscription-manager register) unchanged so the activation-key flow still executes.

coderabbitai · 2026-02-18T16:47:08Z

Dockerfile.oadp

+RUN unlink /etc/rhsm-host
+RUN if [ -e "/activation-key/org" ]; then subscription-manager register --org $(cat "/activation-key/org") --activationkey $(cat "/activation-key/activationkey"); fi


⚠️ Potential issue | 🟡 Minor

Same unlink issue in the final stage.

Apply the same fix here to avoid build failures when /etc/rhsm-host doesn't exist.

Proposed fix

-RUN unlink /etc/rhsm-host +RUN rm -f /etc/rhsm-host || true

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

RUN unlink /etc/rhsm-host

RUN if [ -e "/activation-key/org" ]; then subscription-manager register --org $(cat "/activation-key/org") --activationkey $(cat "/activation-key/activationkey"); fi

RUN rm -f /etc/rhsm-host || true

RUN if [ -e "/activation-key/org" ]; then subscription-manager register --org $(cat "/activation-key/org") --activationkey $(cat "/activation-key/activationkey"); fi

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@Dockerfile.oadp` around lines 22 - 23, The final stage still runs "RUN unlink /etc/rhsm-host" which can fail if the file doesn't exist; change that command to safely remove the file only if present (e.g., check existence or use a no-error removal) so the build won't fail, and keep the existing conditional registration line "RUN if [ -e \"/activation-key/org\" ]; then subscription-manager register --org $(cat \"/activation-key/org\") --activationkey $(cat \"/activation-key/activationkey\"); fi" unchanged except ensuring it follows the safe unlink removal; update the Dockerfile final stage where "unlink /etc/rhsm-host" appears (the RUN unlink /etc/rhsm-host invocation) to use the safe removal approach.

coderabbitai

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@Dockerfile.oadp`:
- Line 11: The RUN unlink /etc/rhsm-host step can fail the build if the file
doesn't exist; change it to a guarded removal such as checking existence before
unlinking (e.g., test -e /etc/rhsm-host && unlink /etc/rhsm-host) or append a
no-fail fallback (e.g., unlink /etc/rhsm-host || true) so the Docker build won't
error when /etc/rhsm-host is absent.

rayfordj · 2026-02-18T19:22:05Z

.tekton/oadp-hypershift-oadp-plugin-main-pull-request.yaml

Suggested change

value: "false"

rayfordj · 2026-02-18T19:22:23Z

.tekton/oadp-hypershift-oadp-plugin-main-push.yaml

Suggested change

value: "false"

Update task bundle references and apply migration changes: - init 0.2→0.3: remove deprecated params (image-url, rebuild, skip-checks) - Remove pipeline-level rebuild parameter - Remove when conditions referencing init.results.build - clair-scan 0.2→0.3: add matrix for image-platform - clamav-scan 0.2→0.3: add matrix for image-arch - ecosystem-cert-preflight-checks: add matrix for platform - Update all task bundle SHA digests to latest versions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>

openshift-ci · 2026-02-19T09:43:22Z

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jparrill mentioned this pull request Feb 16, 2026

OCPBUGS-75913: Fix VolumeSnapshot race condition in backup processing #182

Open

4 tasks

openshift-ci bot requested review from celebdor and muraee February 16, 2026 08:47

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2026

jparrill force-pushed the chore/updates branch from cca1ca6 to 879b3cc Compare February 16, 2026 09:05

openshift-ci bot assigned muraee Feb 16, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2026

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2026

chore(dependencies): Update dependencies to be aligned with Hypershif…

f52ec43

…t repository Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>

jparrill force-pushed the chore/updates branch from 2253be9 to 1ae944a Compare February 18, 2026 16:17

coderabbitai bot reviewed Feb 18, 2026

View reviewed changes

jparrill force-pushed the chore/updates branch from 85f9eb6 to 4afd49b Compare February 18, 2026 16:56

coderabbitai bot reviewed Feb 18, 2026

View reviewed changes

jparrill force-pushed the chore/updates branch from 4afd49b to de79683 Compare February 18, 2026 17:11

rayfordj reviewed Feb 18, 2026

View reviewed changes

.tekton/oadp-hypershift-oadp-plugin-main-pull-request.yaml Outdated

Copy link

Contributor

rayfordj Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

value: "false"

rayfordj reviewed Feb 18, 2026

View reviewed changes

.tekton/oadp-hypershift-oadp-plugin-main-push.yaml Outdated

Copy link

Contributor

rayfordj Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

value: "false"

jparrill force-pushed the chore/updates branch from de79683 to 66180e7 Compare February 19, 2026 09:27

		RUN unlink /etc/rhsm-host
		RUN if [ -e "/activation-key/org" ]; then subscription-manager register --org $(cat "/activation-key/org") --activationkey $(cat "/activation-key/activationkey"); fi

Comments

Conversation

jparrill commented Feb 16, 2026

Uh oh!

coderabbitai bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci bot commented Feb 16, 2026

Uh oh!

muraee commented Feb 16, 2026

Uh oh!

jparrill commented Feb 18, 2026

Uh oh!

openshift-ci bot commented Feb 18, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

rayfordj Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

rayfordj Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Feb 16, 2026 •

edited

Loading