4.22-DNM DOWNSTREAM: <carry>: OCPBUGS-103516: Replace bbolt with patched fork … - #396
4.22-DNM DOWNSTREAM: <carry>: OCPBUGS-103516: Replace bbolt with patched fork …#396sdodson wants to merge 1 commit into
Conversation
…to remove MADV_RANDOM Since Linux 6.4, MADV_RANDOM causes the kernel to aggressively evict mmap'd pages, resulting in major page faults on bbolt's database file and order-of-magnitude compaction duration increases. The RHEL 10 kernel will not revert this behavior change, so the fix must be in bbolt. This adds a go.mod replace directive pointing to a patched bbolt fork with the MADV_RANDOM madvise hint removed. The replace should be dropped once the fix is merged upstream (etcd-io/bbolt#939). Ref: etcd-io/bbolt#939 Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516 Assisted-by: Claude Code (Opus 4.6)
|
@sdodson: This pull request references Jira Issue OCPBUGS-103516, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-control-plane-fips-24nodes /test perfscale-control-plane-6nodes |
|
@sdodson: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1aa9cda0-90cc-11f1-8c35-9451b77da49f-0 |
|
/test perfscale-payload-control-plane-6nodes |
|
@sdodson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…to remove MADV_RANDOM
Since Linux 6.4, MADV_RANDOM causes the kernel to aggressively evict mmap'd pages, resulting in major page faults on bbolt's database file and order-of-magnitude compaction duration increases. The RHEL 10 kernel will not revert this behavior change, so the fix must be in bbolt.
This adds a go.mod replace directive pointing to a patched bbolt fork with the MADV_RANDOM madvise hint removed. The replace should be dropped once the fix is merged upstream (etcd-io/bbolt#939).
Ref: etcd-io/bbolt#939
Ref: https://redhat.atlassian.net/browse/OCPBUGS-103516
Assisted-by: Claude Code (Opus 4.6)
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.