Skip to content

OCPBUGS-95590: Hide Builds nav section when Build capability is disabled - #16891

Open
Leo6Leo wants to merge 1 commit into
openshift:mainfrom
Leo6Leo:OCPBUGS-builds-section-capability
Open

OCPBUGS-95590: Hide Builds nav section when Build capability is disabled#16891
Leo6Leo wants to merge 1 commit into
openshift:mainfrom
Leo6Leo:OCPBUGS-builds-section-capability

Conversation

@Leo6Leo

@Leo6Leo Leo6Leo commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Analysis / Root cause:
When the Build capability is disabled on an OpenShift cluster, the Admin perspective still shows a "Builds" navigation section containing only ImageStreams. This is confusing because the section name implies build functionality that isn't available.

Solution description:

  • Gate the existing ImageStreams navigation entry (under the "builds" section) behind the OPENSHIFT_BUILDCONFIG feature flag so it only appears when builds are enabled.
  • Add a fallback ImageStreams navigation entry under the "storage" section that appears when OPENSHIFT_BUILDCONFIG is disabled, ensuring ImageStreams remains accessible.

Screenshots / screen recording:

Test setup:

  • A cluster with the Build capability disabled

Test cases:

  • With Build capability enabled: ImageStreams appears under Builds section as before
  • With Build capability disabled: Builds section is hidden, ImageStreams appears under Storage section
  • ImageStreams links work correctly in both configurations

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
JIRA: https://redhat.atlassian.net/browse/OCPBUGS-95590

Summary by CodeRabbit

  • New Features
    • ImageStreams navigation now adapts based on build capabilities.
    • Added a storage-focused ImageStreams entry for environments without build support.
    • Existing build-related ImageStreams navigation is shown only when build capabilities are enabled.

When the Build capability is disabled, the Admin perspective still shows a
"Builds" section containing only ImageStreams. Gate the ImageStreams entry
in the "builds" section behind OPENSHIFT_BUILDCONFIG and add a fallback
entry in the "storage" section so ImageStreams remains accessible.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Leo6Leo: This pull request references Jira Issue OCPBUGS-95590, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:
When the Build capability is disabled on an OpenShift cluster, the Admin perspective still shows a "Builds" navigation section containing only ImageStreams. This is confusing because the section name implies build functionality that isn't available.

Solution description:

  • Gate the existing ImageStreams navigation entry (under the "builds" section) behind the OPENSHIFT_BUILDCONFIG feature flag so it only appears when builds are enabled.
  • Add a fallback ImageStreams navigation entry under the "storage" section that appears when OPENSHIFT_BUILDCONFIG is disabled, ensuring ImageStreams remains accessible.

Screenshots / screen recording:

Test setup:

  • A cluster with the Build capability disabled

Test cases:

  • With Build capability enabled: ImageStreams appears under Builds section as before
  • With Build capability disabled: Builds section is hidden, ImageStreams appears under Storage section
  • ImageStreams links work correctly in both configurations

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
JIRA: https://redhat.atlassian.net/browse/OCPBUGS-95590

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9d2fb17c-ec9f-404c-8773-3e55cecba8e2

📥 Commits

Reviewing files that changed from the base of the PR and between 44716b3 and db216ff.

📒 Files selected for processing (1)
  • frontend/packages/console-app/console-extensions.json

Walkthrough

ImageStream navigation is now gated by OPENSHIFT_BUILDCONFIG, with separate builds and storage entries for enabled and disabled states.

Changes

ImageStream navigation

Layer / File(s) Summary
Split ImageStream navigation by build capability
frontend/packages/console-app/console-extensions.json
The builds ImageStreams entry requires OPENSHIFT_BUILDCONFIG; a storage fallback entry is shown when the flag is disallowed.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

  • openshift/console#16888: Updates the same ImageStreams navigation configuration with build-capability gating and a storage fallback.

Suggested reviewers: jeff-phillips-18, logonoff

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: hiding the Builds nav when the Build capability is disabled.
Description check ✅ Passed The description follows the template and includes root cause, solution, tests, setup, and Jira link; screenshots and browser checks are still incomplete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The only changed file is console-extensions.json; no Ginkgo test files or titles were added or modified.
Test Structure And Quality ✅ Passed No Ginkgo tests were changed; the PR only updates console navigation JSON, so this test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes console navigation JSON; no new Ginkgo e2e tests were added, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only console-extensions.json changed; no Ginkgo/e2e tests were added, so SNO multi-node compatibility checks are not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only console navigation JSON changed; no deployment manifests, controllers, pod specs, or scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed Only changed file is a JSON navigation config; no process-level code or stdout writes were added, so the OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only console-extensions.json changed; no Ginkgo e2e tests or network-dependent code were added.
No-Weak-Crypto ✅ Passed Only changed file is navigation JSON; diff adds feature flags for ImageStreams and contains no crypto, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed Only a console navigation JSON changed; no privileged settings, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation, or root container manifests were added.
No-Sensitive-Data-In-Logs ✅ Passed Only a nav config JSON changed; the patch adds no console/log statements or sensitive data literals.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Biome (2.5.5)
frontend/packages/console-app/console-extensions.json

File contains syntax errors that prevent linting: Line 1891: Expected a property but instead found '// The query used to compute the number of kube-apiserver instances that are up'.; Line 1902: End of file expected; Line 1902: End of file expected; Line 1903: Expected an array, an object, or a literal but instead found '// API_SERVERS_UP'.; Line 1902: End of file expected; Line 1903: End of file expected; Line 1904: End of file expected; Line 1904: End of file expected; Line 1906: End of file expected; Line 1906: End of file expected; Line 1908: End of file expected; Line 1908: End of file expected; Line 1910: End of file expected; Line 1911: End of file expected; Line 1912: End of file expected; Line 1912: End of file expected; Line 1912: End of file expected; Line 1914: End of file expected; Line 1915: End of file expected; Line 1915: End of file expected; Line 1915: End of file expected; Line 1917: End of file expected; Line 1918: End of file expected; Line 1918: End of file expecte

... [truncated 2765 characters] ...

expected; Line 2715: End of file expected; Line 2725: End of file expected; Line 2726: End of file expected; Line 2736: End of file expected; Line 2737: End of file expected; Line 2747: End of file expected; Line 2748: End of file expected; Line 2753: End of file expected; Line 2754: End of file expected; Line 2764: End of file expected; Line 2765: End of file expected; Line 2775: End of file expected; Line 2776: End of file expected; Line 2786: End of file expected; Line 2787: End of file expected; Line 2797: End of file expected; Line 2798: End of file expected; Line 2810: End of file expected; Line 2811: End of file expected; Line 2821: End of file expected; Line 2822: End of file expected; Line 2832: End of file expected; Line 2833: End of file expected; Line 2844: End of file expected


Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from spadgett and stefanonardo July 30, 2026 20:04
@openshift-ci openshift-ci Bot added the component/core Related to console core functionality label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Leo6Leo
Once this PR has been reviewed and has the lgtm label, please assign cajieh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@Leo6Leo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core Related to console core functionality jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants