OCPBUGS-95590: Hide Builds nav section when Build capability is disabled - #16891
OCPBUGS-95590: Hide Builds nav section when Build capability is disabled#16891Leo6Leo wants to merge 1 commit into
Conversation
When the Build capability is disabled, the Admin perspective still shows a "Builds" section containing only ImageStreams. Gate the ImageStreams entry in the "builds" section behind OPENSHIFT_BUILDCONFIG and add a fallback entry in the "storage" section so ImageStreams remains accessible. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@Leo6Leo: This pull request references Jira Issue OCPBUGS-95590, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughImageStream navigation is now gated by ChangesImageStream navigation
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.5)frontend/packages/console-app/console-extensions.jsonFile contains syntax errors that prevent linting: Line 1891: Expected a property but instead found '// The query used to compute the number of kube-apiserver instances that are up'.; Line 1902: End of file expected; Line 1902: End of file expected; Line 1903: Expected an array, an object, or a literal but instead found '// API_SERVERS_UP'.; Line 1902: End of file expected; Line 1903: End of file expected; Line 1904: End of file expected; Line 1904: End of file expected; Line 1906: End of file expected; Line 1906: End of file expected; Line 1908: End of file expected; Line 1908: End of file expected; Line 1910: End of file expected; Line 1911: End of file expected; Line 1912: End of file expected; Line 1912: End of file expected; Line 1912: End of file expected; Line 1914: End of file expected; Line 1915: End of file expected; Line 1915: End of file expected; Line 1915: End of file expected; Line 1917: End of file expected; Line 1918: End of file expected; Line 1918: End of file expecte ... [truncated 2765 characters] ... expected; Line 2715: End of file expected; Line 2725: End of file expected; Line 2726: End of file expected; Line 2736: End of file expected; Line 2737: End of file expected; Line 2747: End of file expected; Line 2748: End of file expected; Line 2753: End of file expected; Line 2754: End of file expected; Line 2764: End of file expected; Line 2765: End of file expected; Line 2775: End of file expected; Line 2776: End of file expected; Line 2786: End of file expected; Line 2787: End of file expected; Line 2797: End of file expected; Line 2798: End of file expected; Line 2810: End of file expected; Line 2811: End of file expected; Line 2821: End of file expected; Line 2822: End of file expected; Line 2832: End of file expected; Line 2833: End of file expected; Line 2844: End of file expected Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Leo6Leo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Leo6Leo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Analysis / Root cause:
When the Build capability is disabled on an OpenShift cluster, the Admin perspective still shows a "Builds" navigation section containing only ImageStreams. This is confusing because the section name implies build functionality that isn't available.
Solution description:
OPENSHIFT_BUILDCONFIGfeature flag so it only appears when builds are enabled.OPENSHIFT_BUILDCONFIGis disabled, ensuring ImageStreams remains accessible.Screenshots / screen recording:
Test setup:
Test cases:
Browser conformance:
Additional info:
JIRA: https://redhat.atlassian.net/browse/OCPBUGS-95590
Summary by CodeRabbit