-
Notifications
You must be signed in to change notification settings - Fork 695
[release-4.22] CONSOLE-5011: migrate to yarn berry #15986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| vendor/* linguist-generated=true | ||
| .yarn/releases/** binary | ||
| .yarn/plugins/** binary |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this link really needed? Why not just update demo plugin yarnPath: ../frontend/.yarn/releases/yarn-4.12.0.cjs
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is to reduce config file duplication of |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../frontend/.yarn/releases |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../frontend/.yarnrc.yml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,15 +7,15 @@ | |
| "build": "yarn clean && NODE_ENV=production yarn ts-node node_modules/.bin/webpack", | ||
| "build-dev": "yarn clean && yarn ts-node node_modules/.bin/webpack", | ||
| "build-plugin-sdk": "yarn --cwd ../frontend build-plugin-sdk && yarn install-plugin-sdk", | ||
| "install-plugin-sdk": "rm -rf node_modules/@openshift-console && yarn install --check-files", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does Yarn Berry
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes |
||
| "install-plugin-sdk": "rm -rf node_modules/@openshift-console && yarn install", | ||
| "start-console": "./start-console.sh", | ||
| "http-server": "./http-server.sh dist", | ||
| "i18n": "i18next \"src/**/*.{js,jsx,ts,tsx}\" [-oc] -c i18next-parser.config.js", | ||
| "ts-node": "ts-node -O '{\"module\":\"commonjs\"}'" | ||
| "i18n": "i18next \"src/**/*.{js,jsx,ts,tsx}\" -c i18next-parser.config.js", | ||
| "ts-node": "NODE_OPTIONS='--preserve-symlinks' ts-node -O '{\"module\":\"commonjs\"}'" | ||
| }, | ||
| "devDependencies": { | ||
| "@openshift-console/dynamic-plugin-sdk": "file:../frontend/packages/console-dynamic-plugin-sdk/dist/core", | ||
| "@openshift-console/dynamic-plugin-sdk-webpack": "file:../frontend/packages/console-dynamic-plugin-sdk/dist/webpack", | ||
| "@openshift-console/dynamic-plugin-sdk": "portal:../frontend/packages/console-dynamic-plugin-sdk/dist/core", | ||
| "@openshift-console/dynamic-plugin-sdk-webpack": "portal:../frontend/packages/console-dynamic-plugin-sdk/dist/webpack", | ||
| "@patternfly/react-core": "^6.2.2", | ||
| "@patternfly/react-icons": "^6.2.2", | ||
| "@patternfly/react-table": "^6.2.2", | ||
|
|
@@ -77,5 +77,6 @@ | |
| "utilityConsumer": "./components/UtilityConsumer.tsx", | ||
| "yamlEditor": "./components/YAMLEditorPage.tsx" | ||
| } | ||
| } | ||
| }, | ||
| "packageManager": "yarn@4.12.0" | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, Corepack will setup all supported package managers - we just need Yarn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping by making it generic we won't need to change this again for when we want pnpm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, in that case we can keep it generic.