OCPBUGS-85379: Bump default documentation URL to OCP 4.23#1153
OCPBUGS-85379: Bump default documentation URL to OCP 4.23#1153Cragsmann wants to merge 1 commit into
Conversation
|
@Cragsmann: This pull request references Jira Issue OCPBUGS-85379, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (1)pkg/**/*.go⚙️ CodeRabbit configuration file
Files:
🔀 Multi-repo context openshift/console[::openshift/console::] No file at pkg/console/subresource/configmap (expected by the PR). ls reported "No such file or directory". Findings (references to Red Hat / OCP documentation URLs in this repo):
Reflection: The PR updates a constant in pkg/console/subresource/configmap/brand_ocp.go (console-operator repo). In this repo (openshift/console) there are multiple embedded/documentation links and at least one templated URL (cluster-settings.ts) that constructs OCP-major/minor-based doc URLs; no direct reference to DEFAULT_DOC_URL was found. 🔇 Additional comments (2)
WalkthroughThe ChangesDocumentation URL Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/jira refresh |
|
@Cragsmann: This pull request references Jira Issue OCPBUGS-85379, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jhadvig@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Cragsmann: This pull request references Jira Issue OCPBUGS-85379, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jhadvig@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @Cragsmann. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Cragsmann The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jseseCCS do we know if the next version of docs URL will contain 4.23 or 5.0 |
|
/ok-to-test |
|
@Cragsmann: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
we don't know yet, no. i pinged some teammates to make sure and if i hear differently i'll let you know. |
|
@jhadvig Hey Jakub! Asking the obvious, I know, but since 4.23 docs aren't published yet, should we point this to 4.22 for now? Also, given the uncertainty you mentioned about whether the next version will be 4.23, 5.0, or both, do we have enough clarity to commit to 4.23 here? as i said above, I asked around and will know more soon. On the hardcoded URL: We handle version numbers on the docs side through attributes and variables. I'll look into how consistently we're applying that for cases like this. Is there an equivalent mechanism on the code side that we might be able to leverage here? |
Analysis / Root cause:
Solution description:
Test setup:
Test cases:
Browser conformance:
Additional info:
Reviewers and assignees:
Summary by CodeRabbit