[wip]OTA-1813: Extend alert risk e2e by hongkailiu · Pull Request #1371 · openshift/cluster-version-operator

hongkailiu · 2026-04-10T14:32:51Z

There was an issue of duplicated conditional risks when

a risk whose PromQL cannot be evaluated, and
the risk from alert was accepted.

The issue is fixed by cvo#1367 and this pull is to extend the current alert risk e2e to cover the case.

coderabbitai · 2026-04-10T14:33:00Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 2a98d22a-8c2d-435d-9ac5-ea4881f539e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-04-10T14:33:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [hongkailiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-04-10T15:18:30Z

@hongkailiu: This pull request references OTA-1813 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

There was an issue of duplicated conditional risks when

a risk whose PromQL cannot be evaluated, and

the risk from alert was accepted.

The issue is fixed by cvo#1367 and this pull is to extend the current alert risk e2e to cover the case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

hongkailiu · 2026-04-10T20:34:17Z

test/cvo/accept_risks.go

 		g.By("Using fauxinnati as the upstream and its simple channel")
 		cv.Spec.Upstream = util.FauxinnatiAPIURL
-		cv.Spec.Channel = "simple"
+		cv.Spec.Channel = "OTA-1813"


The channel will return something like this:

$ curl "https://fauxinnati-fauxinnati.apps.ota-stage.q2z4.p1.openshiftapps.com/api/upgrades_info/graph?channel=OTA-1813&version=4.22.0-0.nightly-2026-04-06-051707&arch=amd64" { "nodes": [ { "version": "4.22.0-0.nightly-2026-04-06-051707", "payload": "quay.io/openshift-release-dev/ocp-release@sha256:00000000000000000000000000000000000000000000000000000000003d5ef0", "metadata": { "io.openshift.upgrades.graph.release.channels": "OTA-1813", "io.openshift.upgrades.graph.release.manifestref": "sha256:00000000000000000000000000000000000000000000000000000000003d5ef0", "url": "https://access.redhat.com/errata/RHSA-2024:06200" } }, { "version": "4.22.1", "payload": "quay.io/openshift-release-dev/ocp-release@sha256:00000000000000000000000000000000000000000000000000000000003d5ef1", "metadata": { "io.openshift.upgrades.graph.release.channels": "OTA-1813", "io.openshift.upgrades.graph.release.manifestref": "sha256:00000000000000000000000000000000000000000000000000000000003d5ef1", "url": "https://access.redhat.com/errata/RHSA-2024:06201" } }, { "version": "4.22.2", "payload": "quay.io/openshift-release-dev/ocp-release@sha256:00000000000000000000000000000000000000000000000000000000003d5ef2", "metadata": { "io.openshift.upgrades.graph.release.channels": "OTA-1813", "io.openshift.upgrades.graph.release.manifestref": "sha256:00000000000000000000000000000000000000000000000000000000003d5ef2", "url": "https://access.redhat.com/errata/RHSA-2024:06202" } } ], "edges": [ [ 0, 1 ] ], "conditionalEdges": [ { "edges": [ { "from": "4.22.0-0.nightly-2026-04-06-051707", "to": "4.22.2" } ], "risks": [ { "url": "https://docs.openshift.com/synthetic-risk-a", "name": "SomeInvokerThing", "message": "This is SomeInvokerThing that cannot be evaluated for testing purposes", "matchingRules": [ { "type": "PromQL", "promql": { "promql": "this will fail; muahaha" } } ] } ] } ] }

hongkailiu · 2026-04-10T21:21:42Z

/test e2e-agnostic-ovn-techpreview-serial-1of3

fauxinnati is redeployed a few mins ago.
Let us retry.

There was an issue of duplicated conditional risks when * a risk whose PromQL cannot be evaluated, and * the risk from alert was accepted. The issue is fixed by [cvo#1367](openshift#1367) and this pull is to extend the current alert risk e2e to cover the case.

openshift-ci · 2026-04-11T06:36:59Z

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift-conformance	`fb7df5b`	link	true	`/test e2e-hypershift-conformance`
ci/prow/unit	`fb7df5b`	link	true	`/test unit`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

hongkailiu · 2026-04-11T10:47:12Z

Checking https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1371/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn-techpreview-serial-1of3/2042797732539666432 :

Impressive. passed: (2m1s).

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1371/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn-techpreview-serial-1of3/2042797732539666432/artifacts/e2e-agnostic-ovn-techpreview-serial/openshift-e2e-test/artifacts/e2e.log | grep risks
started: 0/1/44 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with risks from alerts"
passed: (2m1s) 2026-04-11T04:53:15 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with risks from alerts"
started: 0/2/44 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with accept risks"
passed: (1m1s) 2026-04-11T04:54:16 "[Jira:\"Cluster Version Operator\"] cluster-version-operator should work with accept risks"
started: 0/34/44 "[sig-cli][OCPFeatureGate:ClusterUpdateAcceptRisks] oc can operate accept risks [Serial]"
passed: (1.5s) 2026-04-11T05:09:03 "[sig-cli][OCPFeatureGate:ClusterUpdateAcceptRisks] oc can operate accept risks [Serial]"

hongkailiu · 2026-04-11T10:48:44Z

Rerun for more confidence:

/test e2e-agnostic-ovn-techpreview-serial-1of3

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026

hongkailiu changed the title ~~[wip]Extend alert risk e2e~~ [wip]OTA-1813: Extend alert risk e2e Apr 10, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2026

hongkailiu force-pushed the e2e-ota-1813 branch 4 times, most recently from abe6812 to 1a42691 Compare April 10, 2026 19:45

hongkailiu commented Apr 10, 2026

View reviewed changes

Extend alert risk e2e

fb7df5b

There was an issue of duplicated conditional risks when * a risk whose PromQL cannot be evaluated, and * the risk from alert was accepted. The issue is fixed by [cvo#1367](openshift#1367) and this pull is to extend the current alert risk e2e to cover the case.

hongkailiu force-pushed the e2e-ota-1813 branch from 1a42691 to fb7df5b Compare April 11, 2026 02:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wip]OTA-1813: Extend alert risk e2e#1371

[wip]OTA-1813: Extend alert risk e2e#1371
hongkailiu wants to merge 1 commit intoopenshift:mainfrom
hongkailiu:e2e-ota-1813

hongkailiu commented Apr 10, 2026

Uh oh!

coderabbitai bot commented Apr 10, 2026 •

edited

Loading

Review skipped

Uh oh!

openshift-ci bot commented Apr 10, 2026

Uh oh!

openshift-ci-robot commented Apr 10, 2026 •

edited by openshift-ci bot

Loading

Uh oh!

hongkailiu Apr 10, 2026 •

edited

Loading

Uh oh!

hongkailiu commented Apr 10, 2026

Uh oh!

openshift-ci bot commented Apr 11, 2026

Uh oh!

hongkailiu commented Apr 11, 2026

Uh oh!

hongkailiu commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hongkailiu commented Apr 10, 2026

Uh oh!

coderabbitai bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci bot commented Apr 10, 2026

Uh oh!

openshift-ci-robot commented Apr 10, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hongkailiu Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hongkailiu commented Apr 10, 2026

Uh oh!

openshift-ci bot commented Apr 11, 2026

Uh oh!

hongkailiu commented Apr 11, 2026

Uh oh!

hongkailiu commented Apr 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Apr 10, 2026 •

edited

Loading

openshift-ci-robot commented Apr 10, 2026 •

edited by openshift-ci bot

Loading

hongkailiu Apr 10, 2026 •

edited

Loading