NO-JIRA: chore: exclude e2e tests from make test unconditionally#1321
NO-JIRA: chore: exclude e2e tests from make test unconditionally#1321vprashar2929 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThe Makefile's PACKAGES variable definition is refactored to unconditionally exclude the test directory, removing conditional CI-specific logic and computing the value at the top level instead. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ) | ||
|
|
||
| func TestGinkgo(t *testing.T) { | ||
| if os.Getenv("TEST_E2E") != "1" { |
There was a problem hiding this comment.
Will not this cause the e2es to get skipped if TEST_E2E is not set? Which is currently not the case in all the existing e2es?
There was a problem hiding this comment.
correct we have to specify TEST_E2E=1 make test in our CI pipelines as well: https://github.com/openshift/release/blob/main/ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-main.yaml#L62-L62
There was a problem hiding this comment.
Based on https://github.com/openshift/release/blob/main/ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-main.yaml#L77 e2e tests are run as make integration-test.
Also, looks like #1172 added test/cvo structure for future extension. With few/basic tests added recently:
- NO-JIRA: Introduce oc-cli for e2e tests #1267
- OTA-1604: migrate ocp-46922 from otp to cvo repo #1279
Maybe these new e2es are not yet running through the CI?
The `test/cvo` e2e tests require a live OCP cluster and were excluded from make test only when CI=true. This caused make test to fail locally when no cluster is available. This commit makes the exclusion unconditional so make test behaves consistently Signed-off-by: vprashar2929 <vibhu.sharma2929@gmail.com>
vprashar2929
force-pushed
the
test-skip
branch
from
3639b59 to
8e268f1
Compare
vprashar2929
changed the title
|
/retest |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
@vprashar2929: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
DavidHurta
left a comment
DavidHurta
left a comment
There was a problem hiding this comment.
Huge thanks! This is a significant fix.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidHurta, vprashar2929 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/label acknowledge-critical-fixes-only |
openshift-ci
Bot
added
the
acknowledge-critical-fixes-only
|
/retitle NO-JIRA: chore: exclude e2e tests from make test unconditionally |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@vprashar2929: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
The
test/cvoe2e tests require a live OCP cluster and were excluded from make test only when CI=true. This caused make test to fail locally when no cluster is available.This commit makes the exclusion unconditional so make test behaves consistently