Skip to content

Conversation

@neisw
Copy link
Contributor

@neisw neisw commented Jan 18, 2026

Reverts #1279

Tracked in TRT-2511

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to microshift failures for cluster-version-operator should have correct runlevel and scc`

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Payload testing microshift may not be possible in your PR please review the failure and address the issue.

CC: @jiajliu @hongkailiu

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 18, 2026

@neisw: This pull request references OTA-1604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Reverts #1279

Tracked in TRT-2511

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to microshift failures for cluster-version-operator should have correct runlevel and scc`

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Payload testing microshift may not be possible in your PR please review the failure and address the issue.

CC: @jiajliu @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Jan 18, 2026

Walkthrough

The changes remove cluster-dependent test code and utilities from the CVO test suite. A test entry is deleted from the extension manifest, a large live-cluster test block is removed from cvo.go, and the entire util.go file containing Kubernetes and OpenShift client initialization functions is deleted.

Changes

Cohort / File(s) Summary
Test Manifest Configuration
.openshift-tests-extension/openshift_payload_cluster-version-operator.json
Removed one test entry ("cluster-version-operator should have correct runlevel and scc") from the payload; all other entries preserved
Live-Cluster Test Code
test/cvo/cvo.go
Removed BeforeEach setup block and live-cluster test that verified namespace run-level label and CVO pod SCC annotation; eliminated public constant cvoNamespace and Kubernetes-related imports; retained only non-cluster-dependent OC client test
Removed Utility Module
test/cvo/util.go
Entire file deleted; removed helper functions for HyperShift detection, conditional test skipping, and Kubernetes/OpenShift client initialization (IsHypershift, SkipIfHypershift, GetRestConfig, GetKubeClient, GetConfigClient)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@neisw
Copy link
Contributor Author

neisw commented Jan 18, 2026

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2026

@neisw: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiajliu
Copy link
Contributor

jiajliu commented Jan 19, 2026

The case was reverted to unblock the CI tests because we hadn't accounted for it running on microshift. This particular pr is a clean revert of a recently migrated case from OTP to OTE. I will investigate the microshift issue further and address it in TRT-2511. For now, we are bypassing the test to proceed.

/lgtm
/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

@jiajliu: The verified label has been added.

Details

In response to this:

The case was reverted to unblock the CI tests because we hadn't accounted for it running on microshift. This particular pr is a clean revert of a recently migrated case from OTP to OTE. I will investigate the microshift issue further and address it in TRT-2511. For now, we are bypassing the test to proceed.

/lgtm
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026
@petr-muller
Copy link
Member

/approve

does emeritus count?

@hongkailiu
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, jiajliu, neisw, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 9d362fb into openshift:main Jan 19, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants