ci-operator-prowgen: Add boskos credentials on multistage tests in any case

[danilo-gemoli]

We have recently introduced the new "intra-leasing step" feature that allows any step to acquire a lease at execution time, but it requires the boskos' credentials to work.
This means that the previous constraint "make boskos' credentials available when a multistage test uses a cluster profile or the leases stanza right away" doesn't hold anymore.
In this new scenario, a multistage test might need access to boskos regardless.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ba79492e-87bc-4d1b-a0a2-0195f0a33580

📥 Commits

Reviewing files that changed from the base of the PR and between 375ce8f and 90c0134.

📒 Files selected for processing (18)

• cmd/ci-operator-prowgen/testdata/zz_fixture_presubmit_TestFromCIOperatorConfigToProwYaml_Custom_test_timeout.yaml
• pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case.yaml
• pkg/prowgen/jobbase.go
• pkg/prowgen/prowgen.go
• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_literal_multi_stage_test.yaml
• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test.yaml
• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_CSI_enabled.yaml
• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_claim.yaml
• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_releases.yaml
• test/integration/ci-operator-prowgen/output/jobs/sharded/repo/sharded-repo-main-presubmits.yaml
• test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-master-presubmits.yaml
• test/integration/pj-rehearse/candidate/ci-operator/jobs/super/trooper/super-trooper-master-periodics.yaml
• test/integration/pj-rehearse/candidate/ci-operator/jobs/super/trooper/super-trooper-master-presubmits.yaml
• test/integration/pj-rehearse/candidate/ci-operator/jobs/uses/observer/uses-observer-master-presubmits.yaml
• test/integration/pj-rehearse/expected.yaml
• test/integration/pj-rehearse/master/ci-operator/jobs/super/trooper/super-trooper-master-periodics.yaml
• test/integration/pj-rehearse/master/ci-operator/jobs/super/trooper/super-trooper-master-presubmits.yaml
• test/integration/pj-rehearse/master/ci-operator/jobs/uses/observer/uses-observer-master-presubmits.yaml

💤 Files with no reviewable changes (1)

• pkg/prowgen/prowgen.go

✅ Files skipped from review due to trivial changes (7)

• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_claim.yaml
• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_CSI_enabled.yaml
• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test.yaml
• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_literal_multi_stage_test.yaml
• test/integration/ci-operator-prowgen/output/jobs/sharded/repo/sharded-repo-main-presubmits.yaml
• test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-master-presubmits.yaml
• pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_releases.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/prowgen/jobbase.go

---

Walkthrough

Removed the conditional lease-detection helper and moved LeaseClient() pod-spec addition into the specific multi-stage test switch branches; updated numerous test fixtures and generated job YAML to add a lease-server credentials CLI arg and a secret-backed /etc/boskos volume/volumeMount.

Changes

Cohort / File(s)	Summary
Core logic pkg/prowgen/jobbase.go, pkg/prowgen/prowgen.go	Deleted the private testContainsLease helper and relocated LeaseClient() addition so it is unconditionally added inside MultiStageTestConfigurationLiteral / MultiStageTestConfiguration switch cases.
Prowgen test fixtures pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_literal_multi_stage_test.yaml, pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test.yaml, pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_CSI_enabled.yaml, pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_claim.yaml, pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_releases.yaml	Added --lease-server-credentials-file=/etc/boskos/credentials to ci-operator args and a read-only boskos secret volume/volumeMount mapping credentials → credentials under /etc/boskos.
Generated/Integration job outputs test/integration/ci-operator-prowgen/output/jobs/sharded/repo/sharded-repo-main-presubmits.yaml, test/integration/ci-operator-prowgen/output/jobs/super/duper/super-duper-master-presubmits.yaml	Added lease credentials arg and boskos secret-backed volume/volumeMount to affected presubmit job pod specs.
Presubmit fixtures (ci-operator-prowgen) cmd/ci-operator-prowgen/testdata/zz_fixture_presubmit_TestFromCIOperatorConfigToProwYaml_Custom_test_timeout.yaml	Injected lease credentials arg and boskos secret volume/volumeMount into the unit presubmit pod spec.
PRPQR reconciler fixture pkg/controller/prpqr_reconciler/testdata/zz_fixture_prowjobs_TestReconcile_basic_aggregated_case.yaml	Added lease credentials arg and boskos secret volume/volumeMount to the aggregated ProwJob pod spec.
PJ-rehearse candidate changes test/integration/pj-rehearse/candidate/.../ci-operator/jobs/super/trooper/..., test/integration/pj-rehearse/candidate/.../ci-operator/jobs/uses/observer/...	Multiple presubmit and periodic job fixtures updated to add the lease credentials arg and boskos secret-backed volume/volumeMounts.
PJ-rehearse expected & master outputs test/integration/pj-rehearse/expected.yaml, test/integration/pj-rehearse/master/.../ci-operator/jobs/...	Updated expected and master rehearse outputs to include the lease credentials arg and corresponding boskos secret volume/volumeMount across affected job specs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[danilo-gemoli]

/test e2e

[danilo-gemoli]

/test e2e

[openshift-ci-robot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [danilo-gemoli,deepsm007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 489209d and 2 for PR HEAD 90c0134 in total

[danilo-gemoli]

/retest-required

[openshift-ci]

@danilo-gemoli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/breaking-changes	90c0134	link	false	/test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[danilo-gemoli]

/override ci/prow/images

[openshift-ci]

@danilo-gemoli: Overrode contexts on behalf of danilo-gemoli: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e

[danilo-gemoli]

/override ci/prow/images

[openshift-ci]

@danilo-gemoli: Overrode contexts on behalf of danilo-gemoli: ci/prow/images

Details

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.