Skip to content

Add openshift-org-azure Cluster Profile Set#5000

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
danilo-gemoli:feat/ci-operator/openshift-org-azure-profile-set
Mar 10, 2026
Merged

Add openshift-org-azure Cluster Profile Set#5000
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
danilo-gemoli:feat/ci-operator/openshift-org-azure-profile-set

Conversation

@danilo-gemoli
Copy link
Contributor

@danilo-gemoli danilo-gemoli commented Mar 10, 2026

Likewise to #4989

Summary by CodeRabbit

  • New Features
    • Added support for a new OpenShift on Azure cluster profile option, integrated with quota and lease management.

@openshift-ci-robot
Copy link
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b3aed215-da7a-4a91-9b9f-ab40eef8148a

📥 Commits

Reviewing files that changed from the base of the PR and between e01485f and 28b2eb3.

📒 Files selected for processing (1)
  • pkg/api/types.go

Walkthrough

Added a new cluster profile constant ClusterProfileOpenshiftOrgAzure with value "openshift-org-azure" and extended existing methods (ClusterProfiles(), ClusterType(), and LeaseType()) to recognize and properly handle this new profile across cluster type resolution and quota calculations.

Changes

Cohort / File(s) Summary
Cluster Profile Addition
pkg/api/types.go
Introduced new ClusterProfileOpenshiftOrgAzure constant and extended ClusterProfiles(), ClusterType(), and LeaseType() methods to support the new profile, mapping it to "azure4" cluster type and "openshift-org-azure-quota-slice" lease type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and concisely describes the main change: adding a new cluster profile set for OpenShift on Azure.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Stable And Deterministic Test Names ✅ Passed PR modifies only type definitions in pkg/api/types.go with new ClusterProfileOpenshiftOrgAzure constant and related switch cases. No Ginkgo test code present.
Test Structure And Quality ✅ Passed This PR modifies pkg/api/types.go, a types definition file, adding cluster profile constants. The custom check assesses Ginkgo test code quality, which is not present in this PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from Prucek and smg247 March 10, 2026 16:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2026
@danilo-gemoli
Copy link
Contributor Author

/test e2e images

@hector-vido
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, hector-vido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [danilo-gemoli,hector-vido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2026

@danilo-gemoli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes 28b2eb3 link false /test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a6ff4ff into openshift:main Mar 10, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants