-
Notifications
You must be signed in to change notification settings - Fork 294
ROSAENG-16 | create cluster profile for regional e2e #4906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROSAENG-16 | create cluster profile for regional e2e #4906
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
WalkthroughAdds a new cluster profile constant Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing touches
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pkg/api/types.go`:
- Around line 2385-2386: The switch in LeaseTypeFromClusterType() is missing the
"rosa-regional-platform-int" cluster type, causing an error when
ClusterProfileRosaRegionalPlatformInt is used; update the switch (the case block
that already contains values like "aro-hcp-int", "aro-hcp-stg", etc.) to include
"rosa-regional-platform-int" so it maps to the same lease type as LeaseType()
returns for ClusterProfileRosaRegionalPlatformInt
("rosa-regional-platform-int-quota-slice").
7f6c0c2 to
bce09cc
Compare
|
/retest |
|
Scheduling required tests: Scheduling tests matching the |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoan1, deepsm007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e |
|
@deepsm007: Overrode contexts on behalf of deepsm007: ci/prow/e2e DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/breaking-changes |
|
@deepsm007: Overrode contexts on behalf of deepsm007: ci/prow/breaking-changes DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@cdoan1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
With the Rosa Regional Platform work; we want to enable e2e against our custom aws accounts.
Create a cluster profile that can be owned by our org; to create the e2e periodic job