Skip to content

Conversation

@cdoan1
Copy link
Contributor

@cdoan1 cdoan1 commented Jan 21, 2026

With the Rosa Regional Platform work; we want to enable e2e against our custom aws accounts.
Create a cluster profile that can be owned by our org; to create the e2e periodic job

@openshift-ci-robot
Copy link
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

Adds a new cluster profile constant ClusterProfileRosaRegionalPlatformInt = "rosa-regional-platform-int", includes it in ClusterProfiles(), and updates ClusterProfile.ClusterType(), ClusterProfile.LeaseType(), and LeaseTypeFromClusterType to handle the new profile and its lease type "rosa-regional-platform-int-quota-slice".

Changes

Cohort / File(s) Change Summary
Cluster profile & mapping
pkg/api/types.go
Added public constant ClusterProfileRosaRegionalPlatformInt = "rosa-regional-platform-int"; included it in ClusterProfiles(); updated ClusterProfile.ClusterType() to return "rosa-regional-platform-int" for the new profile; updated ClusterProfile.LeaseType() and LeaseTypeFromClusterType() to map to "rosa-regional-platform-int-quota-slice"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pkg/api/types.go`:
- Around line 2385-2386: The switch in LeaseTypeFromClusterType() is missing the
"rosa-regional-platform-int" cluster type, causing an error when
ClusterProfileRosaRegionalPlatformInt is used; update the switch (the case block
that already contains values like "aro-hcp-int", "aro-hcp-stg", etc.) to include
"rosa-regional-platform-int" so it maps to the same lease type as LeaseType()
returns for ClusterProfileRosaRegionalPlatformInt
("rosa-regional-platform-int-quota-slice").

@cdoan1 cdoan1 force-pushed the ROSAENG-16-onboard-profile-rosa-regional-platform branch from 7f6c0c2 to bce09cc Compare January 21, 2026 20:32
@cdoan1
Copy link
Contributor Author

cdoan1 commented Jan 21, 2026

/retest

@openshift-ci-robot
Copy link
Contributor

Scheduling required tests:
/test e2e

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test integration-optional-test

@cdoan1
Copy link
Contributor Author

cdoan1 commented Jan 22, 2026

/retest

1 similar comment
@cdoan1
Copy link
Contributor Author

cdoan1 commented Jan 22, 2026

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoan1, deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026
@deepsm007
Copy link
Contributor

/override ci/prow/e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@deepsm007: Overrode contexts on behalf of deepsm007: ci/prow/e2e

Details

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deepsm007
Copy link
Contributor

/override ci/prow/breaking-changes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@deepsm007: Overrode contexts on behalf of deepsm007: ci/prow/breaking-changes

Details

In response to this:

/override ci/prow/breaking-changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 62d858a and 2 for PR HEAD bce09cc in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@cdoan1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f1009cb into openshift:main Jan 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants