Skip to content

CCO-784: update to pick up tls-min-version and tls-cipher-suites#207

Merged
openshift-merge-bot[bot] merged 7 commits intoopenshift:masterfrom
jstuever:CCO-784
Feb 27, 2026
Merged

CCO-784: update to pick up tls-min-version and tls-cipher-suites#207
openshift-merge-bot[bot] merged 7 commits intoopenshift:masterfrom
jstuever:CCO-784

Conversation

@jstuever
Copy link
Copy Markdown

@jstuever jstuever commented Dec 9, 2025

This change merges in recent upstream changes to pick up tls-min-version and tls-cipher-suite flags. It also updates to using golang v1.25 to be compatible with recent upstream changes.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 9, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 9, 2025

@jstuever: This pull request references CCO-784 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This commit introduces a new command-line flag --tls-min-version to the webhook server. This allows operators to specify the minimum supported TLS version (1.0, 1.1, 1.2, or 1.3), improving security flexibility by allowing the enforcement of stricter TLS protocols.

Assisted-by: gemini-3-pro-preview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from 2uasimojo and suhanime December 9, 2025 23:11
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025
@jstuever jstuever changed the title CCO-784: add flag to configure minimum TLS version for webhook server WIP: CCO-784: add flag to configure minimum TLS version for webhook server Dec 9, 2025
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2025
@2uasimojo
Copy link
Copy Markdown
Member

NB: I think we also want tls-cipher-suites; and eventually something about "curves" once openshift/api#2583 lands.

@jstuever
Copy link
Copy Markdown
Author

This is currently a cherry-pick of the commits posted upstream. Ideally, the upstream PR will merge and we can pull them in directly. If that doesn't happen in time for this release, we may have to carry them until it does.

* feat: add flag to configure minimum TLS version for webhook server

This commit introduces a new command-line flag `--tls-min-version` to the
webhook server. This allows callers to specify the minimum supported TLS
version (1.0, 1.1, 1.2, or 1.3), improving security flexibility by allowing
the enforcement of stricter TLS protocols.

Assisted-by: gemini-3-pro-preview

* feat: add flag to configure TLS cipher suites

This commit introduces a new command-line flag `-tls-cipher-suites` to the
webhook server. This allows users to specify a comma-separated list of
allowed TLS cipher suites, enhancing security configurability.

Assisted-by: gemini-3-pro-preview
@jstuever jstuever changed the title WIP: CCO-784: add flag to configure minimum TLS version for webhook server CCO-784: revendor to pick up tls-min-version and tls-cipher-suites Jan 28, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 28, 2026

@jstuever: This pull request references CCO-784 which is a valid jira issue.

Details

In response to this:

This change merges in recent upstream changes to pick up tls-min-version and tls-cipher-suite flags. It also updates to using golang v1.25 to be compatible with recent upstream changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jstuever
Copy link
Copy Markdown
Author

/assign @dlom

@dlom
Copy link
Copy Markdown

dlom commented Feb 2, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2026
@huangmingxia
Copy link
Copy Markdown

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-private-shared-vpc-phz-sts-mini-perm-f7

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 5, 2026

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-private-shared-vpc-phz-sts-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23745410-02d2-11f1-8288-5fa8a750773c-0

@huangmingxia
Copy link
Copy Markdown

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-wavelength-sts-fips-mini-perm-f14

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 5, 2026

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-wavelength-sts-fips-mini-perm-f14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/280b8f70-02d2-11f1-91bc-a89568a7605e-0

@huangmingxia
Copy link
Copy Markdown

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-azure-mag-ipi-fips-f7

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 5, 2026

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-azure-mag-ipi-fips-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2da01690-02d2-11f1-9f48-2be85117e42f-0

@huangmingxia
Copy link
Copy Markdown

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-azure-ipi-vmgenv1-mini-perm-f7

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 5, 2026

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-azure-ipi-vmgenv1-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/363fe1e0-02d2-11f1-91f8-e3eae1654ee1-0

@jstuever jstuever changed the title CCO-784: revendor to pick up tls-min-version and tls-cipher-suites WIP: CCO-784: revendor to pick up tls-min-version and tls-cipher-suites Feb 18, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2026
This commit enables the ability to specify the tls-min-version using the
names of the constants in crypto/tls/common.go (i.e., VersionTLS10,
VersionTLS11, VersionTLS12, VersionTLS13).

Assisted-by: gemini-3-pro-preview
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2026
@jstuever jstuever changed the title WIP: CCO-784: revendor to pick up tls-min-version and tls-cipher-suites CCO-784: revendor to pick up tls-min-version and tls-cipher-suites Feb 19, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2026
@jstuever jstuever changed the title CCO-784: revendor to pick up tls-min-version and tls-cipher-suites CCO-784: update to pick up tls-min-version and tls-cipher-suites Feb 19, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 19, 2026

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dlom
Copy link
Copy Markdown

dlom commented Feb 25, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@huangmingxia
Copy link
Copy Markdown

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-private-shared-vpc-phz-sts-mini-perm-f7

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 26, 2026

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-aws-ipi-private-shared-vpc-phz-sts-mini-perm-f7

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4092da20-12e6-11f1-9f05-7e9ae7f33baf-0

@huangmingxia
Copy link
Copy Markdown

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-nutanix-ipi-data-disks-f28

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 26, 2026

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-nutanix-ipi-data-disks-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/45f94c60-12e6-11f1-8d67-dd8381f094b5-0

@huangmingxia
Copy link
Copy Markdown

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-vsphere-ipi-amd-f7-netobserv

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 26, 2026

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-vsphere-ipi-amd-f7-netobserv

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/51a3bfa0-12e6-11f1-8e0a-29e3f9c88c85-0

@huangmingxia
Copy link
Copy Markdown

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-ibmcloud-ipi-mini-perm-f28

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 26, 2026

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-ibmcloud-ipi-mini-perm-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5c6cac80-12e6-11f1-8d83-134b1d58034e-0

@huangmingxia
Copy link
Copy Markdown

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-azure-ipi-disc-oidc-mini-perm-f14

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 26, 2026

@huangmingxia: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-azure-ipi-disc-oidc-mini-perm-f14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/69d28b60-12e6-11f1-8d5c-1a9c5f010448-0

@huangmingxia
Copy link
Copy Markdown

huangmingxia commented Feb 27, 2026

/verified by @huangmingxia
For test results, see comments in CCO-784.
Cluster installation regression tests were verified through the CI runs above.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 27, 2026

@huangmingxia: This PR has been marked as verified by @huangmingxia.

Details

In response to this:

/verified by @huangmingxia
For test results, see comments in CCO-784.
Cluster installation regression tests were verified through the CI runs above.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 8208828 into openshift:master Feb 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants