AGENT-1493: Promote NoRegistryClusterInstall Feature to Default

[sadasu]

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

[openshift-ci-robot]

@sadasu: This pull request references AGENT-1394 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target only the "5.0.0" version, but multiple target versions were set.

Details

In response to this:

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR enables the NoRegistryClusterInstall feature gate and introduces the MachineConfigNode CustomResourceDefinition. The feature gate code is updated to support inDefault() and inOKD() deployment profiles, corresponding manifests transition the feature from disabled to enabled status in self-managed and OKD clusters, and documentation reflects the expanded scope. A new MachineConfigNode CRD is added with comprehensive spec and status schemas supporting machine config versioning, release image tracking with per-release conditions, and pinned image set management. Related CRD annotations are cleaned up by removing feature-set and high-availability inclusion markers from internal release image and machineconfig node resources.

Suggested reviewers

• everettraven
• memodi

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description directly relates to the changeset by explaining that the NoRegistryClusterInstall feature is being promoted to default support during Agent installs, which aligns with the actual changes made.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR contains Ginkgo tests with deterministic names based on CRD metadata and YAML specs; no random UUIDs, timestamps, pod names, or other non-deterministic values in test titles.
Test Structure And Quality	✅ Passed	PR contains no Ginkgo test code; custom check for test quality is not applicable. Changes are feature gate promotion and manifest updates without tests.
Microshift Test Compatibility	✅ Passed	PR adds no new Ginkgo e2e tests. Changes are limited to feature gate registration code, documentation, and YAML manifests. MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added in this PR. Changes are limited to feature gate code, Kubernetes manifests (CRDs), feature gate configs, and documentation—not test code.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only modifies feature gate config, CRD schema definitions, and documentation—no deployment manifests or pod scheduling constraints that could break SNO/TNF/TNA/HyperShift topologies.
Ote Binary Stdout Contract	✅ Passed	This PR is for the openshift/api repository (API type definitions), not an OTE test binary. The check is inapplicable as the repo doesn't build OTE extensions that communicate via JSON stdout.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	New Ginkgo tests use local testing framework (envtest) without IPv4 assumptions or external connectivity. YAML test specs use localhost/example.com but as static data, not network operations.
Title check	✅ Passed	The title clearly and specifically describes the main change: promoting the NoRegistryClusterInstall feature to default, which is reflected throughout the PR modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @sadasu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andfasano]

Even if are just spaces, I wasn't expecting a change here

[openshift-ci-robot]

@sadasu: This pull request references AGENT-1493 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sadasu]

/jira refresh

[openshift-ci-robot]

@sadasu: This pull request references AGENT-1493 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@sadasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	e5c1c9a	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yuqi-zhang]

Looks like the IRI object itself is still v1alpha1 only: https://github.com/openshift/api/blob/master/machineconfiguration/v1alpha1/types_internalreleaseimage.go ?

We don't allow GA'ing with a alpha API. We would need to graduate the API to v1 first, before we graduate the dependent feature.