WIP: OCPNODE-4521: Promote AdditionalStorageConfig feature gate to Default

[saschagrunert]

Promote the AdditionalStorageConfig feature gate from
TechPreviewNoUpgrade/DevPreviewNoUpgrade to the Default feature set,
making additional layer stores, image stores, and artifact stores
generally available in OpenShift 5.0.

• Enhancement: OCPNODE-4520: Update enhancement for 5.0 GA target enhancements#2022
• JIRA: https://issues.redhat.com/browse/OCPNODE-4521

cc @haircommander @QiWang19 @sairameshv @harche @bitoku @yuqi-zhang

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@saschagrunert: This pull request references OCPNODE-4521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Promote the AdditionalStorageConfig feature gate from
TechPreviewNoUpgrade/DevPreviewNoUpgrade to the Default feature set,
making additional layer stores, image stores, and artifact stores
generally available in OpenShift 5.0.

• Enhancement: OCPNODE-4520: Update enhancement for 5.0 GA target enhancements#2022
• JIRA: https://issues.redhat.com/browse/OCPNODE-4521

cc @haircommander @QiWang19 @sairameshv @harche @bitoku @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @saschagrunert! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 89cf6a52-eb65-452b-b725-b7b4e59faaae

📥 Commits

Reviewing files that changed from the base of the PR and between 4be619a and bc99e86.

⛔ Files ignored due to path filters (6)

• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• openapi/openapi.json is excluded by !openapi/**

📒 Files selected for processing (11)

• features.md
• features/features.go
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

💤 Files with no reviewable changes (5)

• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs.crd.yaml

---

📝 Walkthrough

Walkthrough

This PR expands the enablement channels for the FeatureGateAdditionalStorageConfig feature gate in features/features.go. The feature gate now activates in default and OKD release channels in addition to its existing tech preview and dev preview modes. The change modifies the enable(...) configuration arguments for this feature gate definition.

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: promoting the AdditionalStorageConfig feature gate from preview to Default.
Description check	✅ Passed	The description directly relates to the changeset by explaining the purpose of promoting AdditionalStorageConfig to Default and references supporting documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies configuration/manifest files only; test YAML files contain only static, descriptive test names with no dynamic content like pod names, timestamps, UUIDs, namespaces, or IP addresses.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test quality is not applicable; PR modifies configuration files, documentation, and Kubernetes manifests, not test code.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The changes consist entirely of feature gate configuration updates, CRD manifest modifications, and documentation changes.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR contains no new Ginkgo e2e tests. Changes are configuration-only: feature gate promotion, CRD manifest updates, and documentation updates. The check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only modifies API definitions (CRDs and feature gates), not deployment manifests or operator code; contains no pod scheduling constraints or topology-unfriendly patterns.
Ote Binary Stdout Contract	✅ Passed	PR modifies YAML, Markdown, and feature gate definitions with no process-level code writing to stdout via fmt, klog, or log packages.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR contains no new Ginkgo e2e tests; only configuration changes to feature gates, documentation, and Kubernetes manifests. Custom check does not apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@saschagrunert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	bc99e86	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[saschagrunert]

The verify-feature-promotion check fails because there are no FeatureGate:AdditionalStorageConfig tagged test runs in Sippy yet. The e2e tests are pending merge in openshift/origin#31083 (approved, CI mostly green). Once that PR merges and accumulates sufficient test history (at least 5 tests per core platform), this check will pass.