Add KubeletConfigAccepted const in 'machineconfiguration/v1/types.go'

[aksjadha]

Related fix: PR

Add new constant `KubeletConfigAccepted KubeletConfigStatusConditionType to update kubeletconfig status.condition.type message to "Accepted"

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3e86a39a-f32e-48fd-925e-2f00e362c0b8

📥 Commits

Reviewing files that changed from the base of the PR and between c4ea330 and a5ee1db.

📒 Files selected for processing (1)

• machineconfiguration/v1/types.go

---

📝 Walkthrough

Walkthrough

This PR adds a new condition type constant, KubeletConfigAccepted, to KubeletConfigStatusConditionType in the machine configuration API types and updates the documentation for KubeletConfigSuccess and KubeletConfigFailure to mark them deprecated in favor of using KubeletConfigAccepted with True/False. The change is limited to the const block in machineconfiguration/v1/types.go.

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding the KubeletConfigAccepted constant to the types.go file.
Description check	✅ Passed	The description is related to the changeset, explaining the purpose of adding the new KubeletConfigAccepted constant for updating kubeletconfig status.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR adds test generator with deterministic test names from CRD specs and YAML files. No generated suffixes, timestamps, UUIDs, or other dynamic values in Describe() or Entry() test titles.
Test Structure And Quality	✅ Passed	PR contains no Ginkgo tests. Changes are limited to adding KubeletConfigAccepted constant and deprecating existing constants in types.go. Ginkgo test quality check is not applicable.
Microshift Test Compatibility	✅ Passed	This PR adds a constant to a types definition file, not new Ginkgo e2e tests. No test code is present in the changes, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only API type definitions in machineconfiguration/v1/types.go (adding KubeletConfigAccepted constant), not Ginkgo e2e tests, making the SNO test compatibility check inapplicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only adds a constant to an API types definition file, not deployment manifests, operator code, or controllers with scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	File contains only type/constant definitions with no stdout writes. No main(), init(), TestMain(), or suite setup functions exist that could violate the OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests; it only adds a constant definition (KubeletConfigAccepted) in types.go. The check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Hello @aksjadha! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @aksjadha. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ngopalak-redhat]

/ok-to-test

[openshift-ci]

@aksjadha: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.