Skip to content

NO-JIRA: Fix Infrastructure PlatformType comment #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2uasimojo wants to merge 1 commit into
base: master
Choose a base branch
from
+198 −149
Open

NO-JIRA: Fix Infrastructure PlatformType comment #2660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions config/v1/types_infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,9 +302,10 @@ type PlatformSpec struct {
// balancers, dynamic volume provisioning, machine creation and deletion, and
// other integrations are enabled. If None, no infrastructure automation is
// enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
// "OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
// "AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
// and must handle unrecognized platforms as None if they do not support that platform.
// "OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
Copy link
Contributor

@JoelSpeed JoelSpeed Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this now reflects the list, we don't actually support Equinix or Alibaba, and I thought oVirt went too. We should probably think about removing those constants from the API at some point

Copy link
Member Author

@2uasimojo 2uasimojo Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...but not in this PR?

Copy link
Member Author

@2uasimojo 2uasimojo Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the ways this list can be used, we wouldn't want to remove a given value until the last OCP release that supports it is EOL, right?

Copy link
Contributor

@JoelSpeed JoelSpeed Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite possibly, of which, it would be the oVirt part. I think that is EOL now though , it went in ~4.14 I think

// "PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
// components may not support all platforms, and must handle unrecognized
// platforms as None if they do not support that platform.
//
// +unionDiscriminator
Type PlatformType `json:"type"`
Expand Down
7 changes: 4 additions & 3 deletions ...nerated.crd-manifests/0000_10_config-operator_01_infrastructures-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,9 +628,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,9 +562,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...ted.crd-manifests/0000_10_config-operator_01_infrastructures-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,9 +628,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,9 +562,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...ed.crd-manifests/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,9 +628,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...generated.featuregated-crd-manifests/infrastructures.config.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,9 +562,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...regated-crd-manifests/infrastructures.config.openshift.io/AWSClusterHostedDNSInstall.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...d.featuregated-crd-manifests/infrastructures.config.openshift.io/AWSDualStackInstall.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...gated-crd-manifests/infrastructures.config.openshift.io/AzureClusterHostedDNSInstall.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...featuregated-crd-manifests/infrastructures.config.openshift.io/AzureDualStackInstall.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...generated.featuregated-crd-manifests/infrastructures.config.openshift.io/DualReplica.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...ted-crd-manifests/infrastructures.config.openshift.io/DyanmicServiceEndpointIBMCloud.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,9 +623,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...regated-crd-manifests/infrastructures.config.openshift.io/GCPClusterHostedDNSInstall.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...crd-manifests/infrastructures.config.openshift.io/HighlyAvailableArbiter+DualReplica.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,9 +562,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...eaturegated-crd-manifests/infrastructures.config.openshift.io/HighlyAvailableArbiter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...d.featuregated-crd-manifests/infrastructures.config.openshift.io/NutanixMultiSubnets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,9 +566,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...ated.featuregated-crd-manifests/infrastructures.config.openshift.io/OnPremDNSRecords.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
7 changes: 4 additions & 3 deletions ...aturegated-crd-manifests/infrastructures.config.openshift.io/VSphereHostVMGroupZonal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,10 @@ spec:
balancers, dynamic volume provisioning, machine creation and deletion, and
other integrations are enabled. If None, no infrastructure automation is
enabled. Allowed values are "AWS", "Azure", "BareMetal", "GCP", "Libvirt",
"OpenStack", "VSphere", "oVirt", "KubeVirt", "EquinixMetal", "PowerVS",
"AlibabaCloud", "Nutanix" and "None". Individual components may not support all platforms,
and must handle unrecognized platforms as None if they do not support that platform.
"OpenStack", "VSphere", "oVirt", "IBMCloud", "KubeVirt", "EquinixMetal",
"PowerVS", "AlibabaCloud", "Nutanix", "External", and "None". Individual
components may not support all platforms, and must handle unrecognized
platforms as None if they do not support that platform.
enum:
- ""
- AWS
Expand Down
Loading