Re-enable NewOLMBoxcutterRuntime featuregate in TPNU

[perdasilva]

PR Type

Enhancement

---

Description

• Re-enable NewOLMBoxCutterRuntime feature gate for self-managed clusters

• Add DevPreviewNoUpgrade and TechPreviewNoUpgrade cluster profiles

• Update feature gate manifests to reflect new enablement configuration

• Fix indentation inconsistency in EVPN feature gate definition

---

Diagram Walkthrough

flowchart LR
  A["NewOLMBoxCutterRuntime<br/>Feature Gate"] -->|"Add cluster profiles"| B["SelfManaged +<br/>DevPreviewNoUpgrade +<br/>TechPreviewNoUpgrade"]
  B -->|"Update manifests"| C["DevPreviewNoUpgrade<br/>Manifest"]
  B -->|"Update manifests"| D["TechPreviewNoUpgrade<br/>Manifest"]

Loading

File Walkthrough

	Relevant files
Enhancement	features.go Enable NewOLMBoxCutterRuntime for cluster profiles              features/features.go Add enableForClusterProfile() call to NewOLMBoxCutterRuntime feature gate with SelfManaged, DevPreviewNoUpgrade, and TechPreviewNoUpgrade profiles Fix indentation of FeatureGateEVPN definition for consistency +7/-6
Documentation	features.md Update feature gate documentation table                                    features.md Reorder NewOLMBoxCutterRuntime row in feature gate table Update status to show enabled for TechPreviewNoUpgrade and SelfManaged profiles +1/-1
Configuration changes	featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml Enable NewOLMBoxCutterRuntime in DevPreviewNoUpgrade manifest payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml Remove NewOLMBoxCutterRuntime from disabled features list Add NewOLMBoxCutterRuntime to enabled features list under NewOLM section +3/-3      featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml Enable NewOLMBoxCutterRuntime in TechPreviewNoUpgrade manifest payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml Remove NewOLMBoxCutterRuntime from disabled features list Add NewOLMBoxCutterRuntime to enabled features list under NewOLM section +3/-3

---

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Hello @perdasilva! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Standardize enabled badge styling Replace inline HTML styles for the 'Enabled' status with a CSS class for better consistency and maintainability. features.md [14] -| NewOLMBoxCutterRuntime| | | | <span style="background-color: #519450">Enabled</span> | | | | <span style="background-color: #519450">Enabled</span> | +| NewOLMBoxCutterRuntime| | | | <span class="fg-enabled">Enabled</span> | | | | <span class="fg-enabled">Enabled</span> | Apply / Chat Suggestion importance[1-10]: 4 __ Why: The suggestion correctly points out that using inline styles is not ideal for maintainability. While the proposed change to use a CSS class is a good practice, it's a minor style improvement and the existing code is consistent with other entries in the same file.	Low
More