Skip to content

Fixing rhobs dependency and inline parameter issues#697

Merged
Ajpantuso merged 1 commit intoopenshift:mainfrom
Ankit152:obo-fix
Feb 26, 2026
Merged

Fixing rhobs dependency and inline parameter issues#697
Ajpantuso merged 1 commit intoopenshift:mainfrom
Ankit152:obo-fix

Conversation

@Ankit152
Copy link
Contributor

What type of PR is this?

(bug/feature/cleanup/documentation/test/refactor)

What this PR does / why we need it?

Which Jira/Github issue(s) this PR fixes?

Fixes #

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster
  • Ran make go-test command locally to run all the unit tests and mock tests locally.
  • Included documentation changes with PR

@Ankit152 Ankit152 marked this pull request as draft February 25, 2026 12:54
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankit152

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2026
@Ankit152
Copy link
Contributor Author

Ankit152 commented Feb 25, 2026

I need your help with few things @Ajpantuso

The github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.89.0 does has the following:

  1. Authorization : link
  2. HTTPConfigWithProxyAndTLSFiles : link
  3. HTTPConfigWithTLSFiles : link
  4. TLSConfig : link
  5. TLSFilesConfig : link
  6. SafeTLSConfig : link

However, in the tests controllers/addon/monitoring_federation_reconciler_test.go , controllers/addon/utils.go and integration/monitoring_federation_test.go they are showing errors as follows:

unknown field Authorization in struct literal of type "github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1".Endpoint

Signed-off-by: Ankit152 <ankitkurmi152@gmail.com>
@Ankit152 Ankit152 marked this pull request as ready for review February 26, 2026 07:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2026
@Ankit152
Copy link
Contributor Author

/retest

@Ankit152
Copy link
Contributor Author

/retest-required

@Ankit152
Copy link
Contributor Author

/retest

@Ajpantuso
Copy link
Contributor

/retest-required

@Ajpantuso Ajpantuso closed this Feb 26, 2026
@Ajpantuso Ajpantuso reopened this Feb 26, 2026
@Ajpantuso
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@Ajpantuso: Overrode contexts on behalf of Ajpantuso: ci/prow/precommit-check

Details

In response to this:

/override ci/prow/precommit-check
/override ci/prow/precommit-check
/override ci/prow/precommit-check
/override ci/prow/precommit-check
/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Ajpantuso
Copy link
Contributor

/override ci/prow/precommit-check
/override ci/prow/lint
/override ci/prow/unit
/override ci/prow/images
/override ci/prow/coverage
/override ci/prow/ci-index-addon-operator-bundle

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@Ajpantuso: Overrode contexts on behalf of Ajpantuso: ci/prow/ci-index-addon-operator-bundle, ci/prow/coverage, ci/prow/images, ci/prow/lint, ci/prow/precommit-check, ci/prow/unit

Details

In response to this:

/override ci/prow/precommit-check
/override ci/prow/lint
/override ci/prow/unit
/override ci/prow/images
/override ci/prow/coverage
/override ci/prow/ci-index-addon-operator-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Ajpantuso Ajpantuso merged commit df33bbc into openshift:main Feb 26, 2026
8 of 9 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@Ankit152: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants