Skip to content

NO-JIRA: Set customizable TNA NUM_WORKERS in common.sh#1869

Open
fracappa wants to merge 2 commits intoopenshift-metal3:masterfrom
fracappa:fcp/feat-add-customizable-tna-workers
Open

NO-JIRA: Set customizable TNA NUM_WORKERS in common.sh#1869
fracappa wants to merge 2 commits intoopenshift-metal3:masterfrom
fracappa:fcp/feat-add-customizable-tna-workers

Conversation

@fracappa
Copy link
Copy Markdown
Contributor

Changing NUM_WORKERS env var in TNA to be customizable.
In this way TNA clusters with day-0 workers could be installed using dev-scripts

This way TNA clusters with day-0 workers could be installed using dev-scripts
@openshift-ci openshift-ci bot requested review from derekhiggins and sadasu March 19, 2026 09:03
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 19, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 19, 2026

Hi @fracappa. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bfournie
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2026
@bfournie
Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2026
@fracappa
Copy link
Copy Markdown
Contributor Author

/test e2e-agent-bad-dns e2e-metal-ipi-bm e2e-metal-ipi-serial-ovn-ipv6 e2e-agent-compact-ipv4-iso-no-registry e2e-metal-ipi-ovn-dualstack

common.sh Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to change this for consistency?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a great idea to future proof it, we might want to validate workers for TNF in the future, @fracappa feel free to add that as well

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 3, 2026

@fracappa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-5control-ipv4 7b4f2ea link false /test e2e-agent-5control-ipv4
ci/prow/e2e-agent-compact-ipv4 7b4f2ea link true /test e2e-agent-compact-ipv4
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 7b4f2ea link false /test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/e2e-metal-ipi-bm 7b4f2ea link true /test e2e-metal-ipi-bm
ci/prow/e2e-metal-ipi-bm-bond 7b4f2ea link false /test e2e-metal-ipi-bm-bond

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants