Add pre-shutdown certificate refresh to maximize cluster restart window #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenShift uses short-lived (24h) intermediate signing certificates that automatically rotate. Leaf certificates are capped by the remaining validity of their signer. If you shut down a cluster when signers are close to expiration, the leaf certs may have very short remaining validity, causing startup failures if the cluster is stopped for too long. This change adds: - helpers/refresh-certificates.sh: Standalone script that forces regeneration of all API server signer certificates with fresh 24-hour validity - Integration with shutdown-cluster.sh to automatically refresh certs before shutting down cluster VMs The helper script can also be run independently when needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fonta-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Since we're now transitioning to stopping/starting hypervisor and clusters frequently, a cert expiration startup problem will be more and more common. This addition to the shutdown-cluster.sh script (and helpers) tries to alleviate the issue
OpenShift uses short-lived (24h) intermediate signing certificates that automatically rotate. Leaf certificates are capped by the remaining validity of their signer. If you shut down a cluster when signers are close to expiration, the leaf certs may have very short remaining validity, causing startup failures if the cluster is stopped for too long.
This change adds:
The helper script can also be run independently when needed.
🤖 Generated with Claude Code