Feat/consys custom formats#354
Open
tipatterson-dev wants to merge 2 commits into
Open
Conversation
… schemas Extend the CustomObsFormat SPI with command-side hooks (getCommandBinding, getCommandSchemaBinding) and an isAutoSelectable flag, and thread the configured customFormats map through the obs, command, command-status, datastream-schema and command-stream-schema handlers so a registered format (e.g. application/swe+proto) can serve its own data and schema views.
… POST Dispatch datastream and control-stream creation to a registered custom format's binding when the embedded schema names it. DataStreamBindingJson gains a custom-format branch ahead of the application/swe+ prefix match; CommandStreamBindingJson buffers the schema object and dispatches on commandFormat, staying backward-compatible (a missing commandFormat still uses the default JSON binding); CommandStreamHandler threads the customFormats map through to the binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an extension for modules to add custom formats. In particular, swe+proto requires that other formats be exposed via the Connected Systems API module. See opensensorhub/osh-addons#224