Fix MongoTasksRefresher to force executor restart on MongoSecurityException#6716
Merged
dinujoh merged 2 commits intoopensearch-project:mainfrom Apr 6, 2026
Merged
Conversation
…eption When DocumentDB revokes old credentials after secret rotation, the pipeline enters a permanent auth failure state because basicAuthChanged() returns false (the secret value in Secrets Manager hasn't changed). Add forceRefresh() to MongoTasksRefresher with exponential backoff (30s, 60s, 120s, max 3 attempts) that restarts the executor with the current config. StreamScheduler now walks the exception cause chain for MongoSecurityException and calls forceRefresh() when detected. If all 3 attempts fail, falls back to the normal hourly scheduled credential refresh. Signed-off-by: Dinu John <86094133+dinujoh@users.noreply.github.com>
dinujoh
requested review from
KarstenSchnitter,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
✅ License Header Check PassedAll newly added files have proper license headers. Great work! 🎉 |
dinujoh
force-pushed
the
fix/mongo-force-refresh-on-auth-failure
branch
from
75acfbd to
754000c
Compare
Signed-off-by: Dinu John <86094133+dinujoh@users.noreply.github.com>
dinujoh
force-pushed
the
fix/mongo-force-refresh-on-auth-failure
branch
from
754000c to
51dc2ac
Compare
graytaylor0
reviewed
Apr 6, 2026
| LOG.info("Forcing credential refresh due to authentication failure (attempt {}/{})", | ||
| forceRefreshAttempts, MAX_FORCE_REFRESH_ATTEMPTS); | ||
| try { | ||
| currentExecutor.shutdownNow(); |
Member
There was a problem hiding this comment.
Won't this block submission of jobs to executor service? I don't see executor service getting reinitialized just a new StreamScheduler job getting submitted
Member
There was a problem hiding this comment.
Nevermind I see this creates a new executor
this.currentExecutor = executorServiceFunction.apply(runnables.size());
Member
Author
There was a problem hiding this comment.
graytaylor0
approved these changes
Apr 6, 2026
divbok
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When DocumentDB revokes old credentials after secret rotation, the pipeline enters a permanent auth failure state because basicAuthChanged() returns false (the secret value in Secrets Manager hasn't changed).
Add forceRefresh() to MongoTasksRefresher with exponential backoff (30s, 60s, 120s, max 3 attempts) that restarts the executor with the current config.
StreamScheduler now walks the exception cause chain for MongoSecurityException and calls forceRefresh() when detected. If all 3 attempts fail, falls back to the normal hourly scheduled credential refresh.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.