Fix initial load completion tracking race condition#6711
Open
lawofcycles wants to merge 1 commit intoopensearch-project:mainfrom
Open
Fix initial load completion tracking race condition#6711lawofcycles wants to merge 1 commit intoopensearch-project:mainfrom
lawofcycles wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
creation loop in performInitialLoad(). Previously, the completion key was created after all partitions, allowing workers to finish and call incrementSnapshotCompletionCount() before the key existed. Those increments were silently lost, causing waitForSnapshotComplete() to never reach the expected total. Signed-off-by: Sotaro Hikita <bering1814@gmail.com>
lawofcycles
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the completion tracking GlobalState creation to before the task partition loop in
performInitialLoad(). Previously it was created after all partitions, so workers that finished before the key existed would silently lose their completion increments, preventing the initial load from completing.Issues Resolved
Resolves #6686
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.